From 8d7e4e45a2bd67dac1f12aa4ed8c7549749a7152 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 21 Jun 2017 13:13:17 +0200 Subject: [PATCH] Bug 18980: Add remark next to "Anyone seeing this list" permission MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea behind bug 10865 by adding a remark next to the Anyone permission if it is not actually effective. A next patch will make it behave dynamically. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Verify that you see the remark now in OPAC and staff. Signed-off-by: Marcel de Rooy Signed-off-by: Marc VĂ©ron --- .../prog/en/modules/virtualshelves/shelves.tt | 29 ++++++++++++++++------ .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 15 ++++++++--- 2 files changed, 33 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt index d28250a..2b32ca0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt @@ -9,6 +9,26 @@ [% INCLUDE 'datatables.inc' %] +[% BLOCK list_permissions %] +
  • + + +   The Anyone permission has no actual effect while this list is strictly private. +
  • +[% END %] + [% IF print %]