Bugzilla – Attachment 65285 Details for
Bug 18976
Fix t/db_dependent/Auth.t cleanup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup
Bug-18976-follow-up-Fix-tdbdependentSearchHistoryt.patch (text/plain), 1.51 KB, created by
Jonathan Druart
on 2017-07-26 17:38:11 UTC
(
hide
)
Description:
Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-07-26 17:38:11 UTC
Size:
1.51 KB
patch
obsolete
>From 6d8b26b01f505771fe0d359d29fff8bc963e5291 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@jns.fi> >Date: Mon, 24 Jul 2017 18:16:25 +0300 >Subject: [PATCH] Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t > cleanup > >Same problem in t/db_dependent/Search/History.t. > >To replicate: >1. Check the row count of borrowers, branches, categories, sessions, sms_providers > tables >2. prove t/db_dependent/Search/History.t >3. Repeat step 1 >4. Observe borrowers the following tables have increased in row count: > - borrowers > - branches > - categories > - sessions > - sms_providers > >To test: >1. Before applying the patch, go through steps at "To replicate" plan >2. Apply patch >3. Go through steps at "To replicate" plan >4. Observe step 4 no longer applies and those tables have the same number of > rows as before executing the test. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Search/History.t | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/t/db_dependent/Search/History.t b/t/db_dependent/Search/History.t >index a10b5f8f9f..fc7f0634eb 100644 >--- a/t/db_dependent/Search/History.t >+++ b/t/db_dependent/Search/History.t >@@ -24,6 +24,10 @@ my $schema = Koha::Database->new->schema; > $schema->storage->txn_begin; > my $dbh = C4::Context->dbh; > >+# FIXME: SessionStorage defaults to mysql, but it seems to break transaction >+# handling >+t::lib::Mocks::mock_preference( 'SessionStorage', 'tmp' ); >+ > use_ok('Koha::DateUtils'); > use_ok('C4::Search::History'); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18976
:
65195
|
65197
|
65284
| 65285 |
65390