Bugzilla – Attachment 65304 Details for
Bug 18996
SIP sets ok flag to true for refused checkin for data corruption
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18996: What about adding $circ->ok to the second clause ?
Bug-18996-What-about-adding-circ-ok-to-the-second-.patch (text/plain), 1000 bytes, created by
Marcel de Rooy
on 2017-07-28 09:39:45 UTC
(
hide
)
Description:
Bug 18996: What about adding $circ->ok to the second clause ?
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-07-28 09:39:45 UTC
Size:
1000 bytes
patch
obsolete
>From ca8de07d2e68e98f813d852cf2ed260af66b3143 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 28 Jul 2017 11:38:54 +0200 >Subject: [PATCH] Bug 18996: What about adding $circ->ok to the second clause ? >Content-Type: text/plain; charset=utf-8 > >Proposal needs feedback from preferably Colin. >--- > C4/SIP/ILS.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 35879af..1c90584 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -216,7 +216,7 @@ sub checkin { > > # It's ok to check it in if it exists, and if it was checked out > # or it was not checked out but the checked_in_ok flag was set >- $circ->ok( ( $checked_in_ok && $item ) || ( $item && $item->{patron} ) ); >+ $circ->ok( ( $checked_in_ok && $item ) || ( $item && $item->{patron} && $circ->ok ) ); > syslog("LOG_DEBUG", "C4::SIP::ILS::checkin - using checked_in_ok") if $checked_in_ok; > > if ( !defined( $item->{patron} ) ) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18996
:
65303
|
65304
|
65330
|
65336
|
65393
|
65394
|
65418
|
65961
|
65962
|
65963
|
65964
|
66180
|
66181
|
66182
|
66183
|
66184
|
67055
|
67056
|
67057
|
67058
|
67059
|
67849