From 19932fa5ad220512d5fc7393ea6522f490759761 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 28 Jul 2017 10:29:51 +0200 Subject: [PATCH] Bug 17680: [QA Follow-up] dt_from_string failing silently This is a trivial fix, but finding the cause for a failing checkin in SIPServer surely was not. Without this simple change, I could not checkin an item while the SIP server just closed the connection and syslog contained nothing useful. The error can be easily reproduced without this patch by: use Modern::Perl; use C4::SIP::ILS::Item; my $item = C4::SIP::ILS::Item->new('some_barcode'); where some_barcode should refer to an item checked out. You should trigger the error (with your due date): 2017-07-28 23:59:00 is not an object at line 3. Why the ILS/Item.pm module still compiles without a warning, is not clear though. Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell --- C4/SIP/ILS/Item.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm index 7ef1d3a5be..12bf1aac5e 100644 --- a/C4/SIP/ILS/Item.pm +++ b/C4/SIP/ILS/Item.pm @@ -25,6 +25,7 @@ use C4::Reserves; use Koha::Database; use Koha::Biblios; use Koha::Checkouts; +use Koha::DateUtils; use Koha::Patrons; use Koha::Items; -- 2.13.3