Bugzilla – Attachment 65503 Details for
Bug 18633
Logs are full of CGI::param called in list context - itemsearch.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18633: Remove remaining use of CGI.param in template [16.11.x]
Bug-18633-Remove-remaining-use-of-CGIparam-in-temp.patch (text/plain), 1.69 KB, created by
Mark Tompsett
on 2017-08-04 14:33:53 UTC
(
hide
)
Description:
Bug 18633: Remove remaining use of CGI.param in template [16.11.x]
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-08-04 14:33:53 UTC
Size:
1.69 KB
patch
obsolete
>From d61d4236ad4bb1c6988f395e686e735c28636d95 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Mon, 12 Jun 2017 09:18:30 +0200 >Subject: [PATCH] Bug 18633: Remove remaining use of CGI.param in template > [16.11.x] >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > catalogue/itemsearch.pl | 3 +++ > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt | 3 +-- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/catalogue/itemsearch.pl b/catalogue/itemsearch.pl >index fa6b357..12ef3b4 100755 >--- a/catalogue/itemsearch.pl >+++ b/catalogue/itemsearch.pl >@@ -243,6 +243,9 @@ if (scalar keys %params > 0) { > my $pagination_bar = pagination_bar($url, $nb_pages, $current_page, 'page'); > > $template->param(pagination_bar => $pagination_bar); >+ } elsif ($format eq 'json') { >+ $template->param(sEcho => scalar $cgi->param('sEcho')); >+ output_with_http_headers $cgi, $cookie, $template->output, 'json'; > } > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt >index 35e020f..4bc2add 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt >@@ -1,6 +1,5 @@ >-[%- USE CGI -%] > { >- "sEcho": [% CGI.param('sEcho') %], >+ "sEcho": [% sEcho %], > "iTotalRecords": [% total_rows %], > "iTotalDisplayRecords": [% total_rows %], > "aaData": [ >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18633
:
64123
|
64193
|
64709
|
64710
|
64721
|
64722
|
64900
|
64901
|
65502
| 65503