Bugzilla – Attachment 6552 Details for
Bug 7313
Untranslatable strings in 'search to hold' feature
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7313: Untranslatable strings in 'Search to hold' feature
Bug-7313-Untranslatable-strings-in-Search-to-hold-.patch (text/plain), 5.11 KB, created by
Katrin Fischer
on 2011-12-03 08:56:50 UTC
(
hide
)
Description:
Bug 7313: Untranslatable strings in 'Search to hold' feature
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2011-12-03 08:56:50 UTC
Size:
5.11 KB
patch
obsolete
>From 326ef989630482400d2bf1ac17d245311530ee7c Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sat, 3 Dec 2011 09:55:44 +0100 >Subject: [PATCH] Bug 7313: Untranslatable strings in 'Search to hold' feature > >Changed the javascript to include markup for translation _(...) in result >list and detail page tool bars. > >Also changed the text shown for each result to match the text in the toolbar >to make things more consistent. > >To test: >- Apply patch >- Run "perl translate update <your language code>" >- Open .po file for staff and check for "Place hold on" and "Forget" >- Translate those >- Run "perl translate install <your language code>" >- Activate "Search for hold" feature in patron account >- Do a search and check tool bar on top of result list >- Check link text shown in result list >- Check detail page >--- > .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 6 +++--- > .../prog/en/modules/catalogue/results.tt | 10 +++++----- > 2 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >index 6c7ffae..5ae91ce 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc >@@ -158,8 +158,8 @@ function confirm_items_deletion() { > location.href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]"; > } > var HoldForButtonMenu = [ >- { text: "Place hold", url: "/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]" }, >- { text: "Place hold for [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])", url: "/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]&findborrower=[% holdfor_cardnumber %]" } >+ { text: _("Place hold"), url: "/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]" }, >+ { text: _("Place hold for")+ " [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])", url: "/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]&findborrower=[% holdfor_cardnumber %]" } > ]; > > // Instantiate a Split Button using the array of YAHOO.widget.MenuItem >@@ -169,7 +169,7 @@ function confirm_items_deletion() { > var HoldForButton = new YAHOO.widget.Button({ > id: "holdfor", > type: "split", >- label: "Place hold", >+ label: _("Place hold"), > name: "holdfor", > menu: HoldForButtonMenu, > container: this, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 2bed51c..9ea3fae 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -194,13 +194,13 @@ YAHOO.util.Event.onContentReady("searchheader", function () { > placeHold(); > } > var HoldForButtonMenu = [ >- { text: "Place hold", onclick: { fn: holdFor }}, >- { text: "Place hold for [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])", onclick: { fn: holdForPatron }}, >- { text: "Forget [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])", onclick: { fn: forgetPatron }}]; >+ { text: _("Place hold"), onclick: { fn: holdFor }}, >+ { text: _("Place hold for") + " [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])", onclick: { fn: holdForPatron }}, >+ { text: _("Forget") + " [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])", onclick: { fn: forgetPatron }}]; > > var HoldForButton = new YAHOO.widget.Button({ > type: "split", >- label: "Place hold", >+ label: _("Place hold"), > name: "holdfor", > menu: HoldForButtonMenu, > container: "placeholdc", >@@ -513,7 +513,7 @@ YAHOO.util.Event.onContentReady("searchheader", function () { > <span class="noholdstext">No holds allowed</span> > [% ELSE %] > <a id="reserve_[% SEARCH_RESULT.biblionumber %]" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Holds</a> >- [% IF ( holdfor ) %] <span class="holdforlink">| <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]&findborrower=[% holdfor_cardnumber %]">Hold for [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])</a></span>[% END %] >+ [% IF ( holdfor ) %] <span class="holdforlink">| <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]&findborrower=[% holdfor_cardnumber %]">Place hold for [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])</a></span>[% END %] > [% END %] > [% IF ( CAN_user_editcatalogue_edit_catalogue ) %] > | <a href="/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Edit record</a> >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7313
:
6550
|
6551
|
6552
|
6559