Bugzilla – Attachment 65962 Details for
Bug 18996
SIP sets ok flag to true for refused checkin for data corruption
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Resolve an uninitialized warning from ILS/Item.pm
0002-Bug-18996-Resolve-an-uninitialized-warning-from-ILS-.patch (text/plain), 1.30 KB, created by
Colin Campbell
on 2017-08-14 16:45:53 UTC
(
hide
)
Description:
Resolve an uninitialized warning from ILS/Item.pm
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2017-08-14 16:45:53 UTC
Size:
1.30 KB
patch
obsolete
>From dbcbedea8c2c64c0e843e8e64c427d8302fa389a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 1 Aug 2017 14:10:56 +0200 >Subject: [PATCH 2/4] Bug 18996: Resolve an uninitialized warning from > ILS/Item.pm > >From the syslog call on line 107/108. The field $item->{title} has not >been initialized. When catching the warns in a test script with Test::Warn, >I got: > Use of uninitialized value $args[1] in sprintf at /usr/lib/x86_64-linux-gnu/perl/5.20/Sys/Syslog.pm line 423. > >This simply resolves the warning. We might have a closer look to this title >field on another report though. > >Test plan: >Run Message.t from the next patch without this fix. It will fail since the >additional warning makes warnings_like return false. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> >--- > C4/SIP/ILS/Item.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm >index 12bf1aac5e..4e5441f449 100644 >--- a/C4/SIP/ILS/Item.pm >+++ b/C4/SIP/ILS/Item.pm >@@ -105,7 +105,7 @@ sub new { > bless $self, $type; > > syslog("LOG_DEBUG", "new ILS::Item('%s'): found with title '%s'", >- $item_id, $self->{title}); >+ $item_id, $self->{title}//'' ); > > return $self; > } >-- >2.13.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18996
:
65303
|
65304
|
65330
|
65336
|
65393
|
65394
|
65418
|
65961
|
65962
|
65963
|
65964
|
66180
|
66181
|
66182
|
66183
|
66184
|
67055
|
67056
|
67057
|
67058
|
67059
|
67849