From 94d88fc5e8c5e484a7e873edd95be471e961fe4c Mon Sep 17 00:00:00 2001 From: Amit Gupta Date: Mon, 14 Aug 2017 22:41:36 +0530 Subject: [PATCH] Bug 19086 Stored XSS in boraccount.pl 1. Hit /cgi-bin/koha/members/boraccount.pl?borrowernumber=xx xx is a borrowernumber 2. Notice java script is execute. 3. Apply patch. 4. Reload page, and hit the page again /cgi-bin/koha/members/boraccount.pl?borrowernumber=xx xx is a borrowernumber 5. Notice it is no longer executed. --- members/boraccount.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/members/boraccount.pl b/members/boraccount.pl index 8abb373..6e0baf3 100755 --- a/members/boraccount.pl +++ b/members/boraccount.pl @@ -24,7 +24,7 @@ use strict; use warnings; - +use HTML::Entities; use C4::Auth; use C4::Output; use CGI qw ( -utf8 ); @@ -50,6 +50,7 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user( ); my $borrowernumber=$input->param('borrowernumber'); +$borrowernumber = HTML::Entities::encode($borrowernumber); my $action = $input->param('action') || ''; #get patron details -- 1.7.9.5