Bugzilla – Attachment 65971 Details for
Bug 19100
XSS Flaws in memberentry.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19100 - XSS Flaws in memberentry.pl
0001-Bug-19100-XSS-Flaws-in-memberentry.pl.patch (text/plain), 1.34 KB, created by
Amit Gupta
on 2017-08-14 17:38:26 UTC
(
hide
)
Description:
Bug 19100 - XSS Flaws in memberentry.pl
Filename:
MIME Type:
Creator:
Amit Gupta
Created:
2017-08-14 17:38:26 UTC
Size:
1.34 KB
patch
obsolete
>From f9ce068b23905728daba2baaa7cf2cf9c7471983 Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Mon, 14 Aug 2017 23:00:22 +0530 >Subject: [PATCH] Bug 19100 - XSS Flaws in memberentry.pl > >1. Hit /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> > xx - is a guarantorid >2. Notice the java script is executed. >3. Apply patch. >4. Reload page, and hit the page again /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx<script>alert('amit')</script> > xx - is a guarantorid. >5. Notice it is no longer executed. >--- > members/memberentry.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 0501534..92836f2 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -25,7 +25,7 @@ use warnings; > # external modules > use CGI qw ( -utf8 ); > use List::MoreUtils qw/uniq/; >- >+use HTML::Entities; > # internal modules > use C4::Auth; > use C4::Context; >@@ -81,6 +81,7 @@ if ( C4::Context->preference('SMSSendDriver') eq 'Email' ) { > } > > my $guarantorid = $input->param('guarantorid'); >+$guarantorid = HTML::Entities::encode($guarantorid); > my $borrowernumber = $input->param('borrowernumber'); > my $actionType = $input->param('actionType') || ''; > my $modify = $input->param('modify'); >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19100
:
65971
|
66033
|
66035
|
66065