Bugzilla – Attachment 65981 Details for
Bug 19102
XSS Flaws in circulation.pl - routing-lists.pl - readingrec.pl - notices.pl - maninvoice.pl - boraccount.pl - mancredit.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19102 Fix XSS in maninvoice.pl
0001-Bug-19102-Fix-XSS-in-maninvoice.pl.patch (text/plain), 1.19 KB, created by
Amit Gupta
on 2017-08-14 20:03:57 UTC
(
hide
)
Description:
Bug 19102 Fix XSS in maninvoice.pl
Filename:
MIME Type:
Creator:
Amit Gupta
Created:
2017-08-14 20:03:57 UTC
Size:
1.19 KB
patch
obsolete
>From 6e07ec2952f926c93037fb778540148c40d03fe6 Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Mon, 14 Aug 2017 22:36:39 +0530 >Subject: [PATCH] Bug 19102 Fix XSS in maninvoice.pl > >1. Hit /cgi-bin/koha/members/maninvoice.pl?borrowernumber=xx<script>alert('amit')</script> > xx is a borrowernumber >2. Notice java script is execute. >3. Apply patch. >4. Reload page, and hit the page again /cgi-bin/koha/members/maninvoice.pl?borrowernumber=xx<script>alert('amit')</script> > xx is a borrowernumber >5. Notice it is no longer executed. >--- > members/maninvoice.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/members/maninvoice.pl b/members/maninvoice.pl >index 2c1c05f..203b0f2 100755 >--- a/members/maninvoice.pl >+++ b/members/maninvoice.pl >@@ -24,7 +24,7 @@ > > use strict; > use warnings; >- >+use HTML::Entities; > use C4::Auth; > use C4::Output; > use CGI qw ( -utf8 ); >@@ -41,6 +41,7 @@ my $input=new CGI; > my $flagsrequired = { borrowers => 1 }; > > my $borrowernumber=$input->param('borrowernumber'); >+$borrowernumber = HTML::Entities::encode($borrowernumber); > > my $patron = Koha::Patrons->find( $borrowernumber ); > my $add=$input->param('add'); >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19102
:
65975
|
65976
|
65977
|
65978
|
65979
|
65980
|
65981
|
65982
|
65983
|
66069
|
66070
|
66071
|
66072
|
66073
|
66074
|
66075