From ee18b01fcb871522596723a4f0a44476bbef2560 Mon Sep 17 00:00:00 2001 From: Amit Gupta Date: Tue, 15 Aug 2017 08:52:40 +0530 Subject: [PATCH] Bug 19103 - Stored XSS in itemtypes.pl To Test 1. Hit the page /cgi-bin/koha/admin/itemtypes.pl 2. Add a text in the field Description, Checkin message that contains js 2. Save the page. 3. Notice js is execute 4. Apply patch and reload, the js is escaped --- .../prog/en/modules/admin/itemtypes.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt index 0d07187..66b345f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt @@ -376,7 +376,7 @@ Item types administration
[% END %] [% ELSE %] - [% itemtype.description %] + [% itemtype.description |html %] [% END %] [% itemtype.searchcategory %] @@ -387,7 +387,7 @@ Item types administration [% itemtype.rentalcharge | $Price %] [% END %] - [% itemtype.checkinmsg | html_line_break %] + [% itemtype.checkinmsg | html_line_break |html %] Edit Delete -- 1.7.9.5