Bugzilla – Attachment 65991 Details for
Bug 19103
Stored XSS in itemtypes.pl - patron-attr-types.pl - matching-rules.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19103 - Stored XSS in itemtypes.pl
0001-Bug-19103-Stored-XSS-in-itemtypes.pl.patch (text/plain), 1.83 KB, created by
Amit Gupta
on 2017-08-15 03:25:07 UTC
(
hide
)
Description:
Bug 19103 - Stored XSS in itemtypes.pl
Filename:
MIME Type:
Creator:
Amit Gupta
Created:
2017-08-15 03:25:07 UTC
Size:
1.83 KB
patch
obsolete
>From ee18b01fcb871522596723a4f0a44476bbef2560 Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Tue, 15 Aug 2017 08:52:40 +0530 >Subject: [PATCH] Bug 19103 - Stored XSS in itemtypes.pl > >To Test >1. Hit the page /cgi-bin/koha/admin/itemtypes.pl >2. Add a text in the field Description, Checkin message that contains js >2. Save the page. >3. Notice js is execute >4. Apply patch and reload, the js is escaped >--- > .../prog/en/modules/admin/itemtypes.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >index 0d07187..66b345f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >@@ -376,7 +376,7 @@ Item types administration > <br/> > [% END %] > [% ELSE %] >- [% itemtype.description %] >+ [% itemtype.description |html %] > [% END %] > </td> > <td>[% itemtype.searchcategory %]</td> >@@ -387,7 +387,7 @@ Item types administration > [% itemtype.rentalcharge | $Price %] > [% END %] > </td> >- <td>[% itemtype.checkinmsg | html_line_break %]</td> >+ <td>[% itemtype.checkinmsg | html_line_break |html %]</td> > <td class="actions"> > <a href="/cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=[% itemtype.itemtype |html %]" class="btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a> > <a href="/cgi-bin/koha/admin/itemtypes.pl?op=delete_confirm&itemtype=[% itemtype.itemtype |html %]" class="btn btn-default btn-xs"><i class="fa fa-trash"></i> Delete</a> >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19103
:
65991
|
65995
|
65996
|
66086
|
66087
|
66088
|
66439
|
66440
|
66441
|
67084