Bugzilla – Attachment 66010 Details for
Bug 15644
City dropdown default selection when modifying a patron matches only on city
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15644 - City dropdown default selection when modifying a patron matches only on city
0001-Bug-15644-City-dropdown-default-selection-when-modif.patch (text/plain), 3.98 KB, created by
Amit Gupta
on 2017-08-15 12:33:28 UTC
(
hide
)
Description:
Bug 15644 - City dropdown default selection when modifying a patron matches only on city
Filename:
MIME Type:
Creator:
Amit Gupta
Created:
2017-08-15 12:33:28 UTC
Size:
3.98 KB
patch
obsolete
>From 411501a6e0b7ba0f0e7430b0d3dbdd00d10d87fd Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 8 Jun 2017 16:01:32 +0000 >Subject: [PATCH] Bug 15644 - City dropdown default selection when modifying a > patron matches only on city > >This patch modifies the include files which contain the form fields for >city, state, zipcode, etc. shown on the patron entry screen. The files >are modified so that the city/state/zip <select> preselects a value >based on city, state, and zipcode matching the values in the >corresponding text fields. > >To test, confirm that the bug's steps to reproduce are fixed: > >- Enter two cities via Administration -> Patrons and circulation > -> Cities and towns: > Springfield, MA 01101 > Springfield, VT 05156 >- Edit a patron choosing, Springfield VT, and save. >- Edit the patron again and confirm that the correct city is > pre-selected. >- Confirm this result with all three different settings of the > "AddressFormat" system preference. > >Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> >--- > .../en/includes/member-main-address-style-de.inc | 2 +- > .../en/includes/member-main-address-style-fr.inc | 2 +- > .../en/includes/member-main-address-style-us.inc | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc >index d047400..754b37c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc >@@ -84,7 +84,7 @@ > <select id="select_city" name="select_city"> > <option value="|||"></option> > [% FOREACH c IN cities %] >- [% IF c.city_name == city %] >+ [% IF c.city_name == city && c.city_state == state && c.city_zipcode == zipcode %] > <option value="[% c.city_zipcode %]|[% c.city_name %]|[% c.city_state %]|[% c.city_country %]" selected="selected"> > [% ELSE %] > <option value="[% c.city_zipcode %]|[% c.city_name %]|[% c.city_state %]|[% c.city_country %]"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc >index 4e8dc80..b67d96b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-fr.inc >@@ -83,7 +83,7 @@ > <select id="select_city" name="select_city"> > <option value="|||"></option> > [% FOREACH c IN cities %] >- [% IF c.city_name == city %] >+ [% IF c.city_name == city && c.city_state == state && c.city_zipcode == zipcode %] > <option value="[% c.city_zipcode %]|[% c.city_name %]|[% c.city_state %]|[% c.city_country %]" selected="selected"> > [% ELSE %] > <option value="[% c.city_zipcode %]|[% c.city_name %]|[% c.city_state %]|[% c.city_country %]"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc >index b7115c6..f50d816 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc >@@ -72,7 +72,7 @@ > <select id="select_city" name="select_city"> > <option value="|||"></option> > [% FOREACH c IN cities %] >- [% IF c.city_name == city %] >+ [% IF c.city_name == city && c.city_state == state && c.city_zipcode == zipcode %] > <option value="[% c.city_zipcode %]|[% c.city_name %]|[% c.city_state %]|[% c.city_country %]" selected="selected"> > [% ELSE %] > <option value="[% c.city_zipcode %]|[% c.city_name %]|[% c.city_state %]|[% c.city_country %]"> >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15644
:
64082
|
64111
|
66010
|
67002