Bugzilla – Attachment 66047 Details for
Bug 19114
Stored XSS in parcels.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 19114 - Stored XSS in parcels.pl
SIGNED-OFF-Bug-19114---Stored-XSS-in-parcelspl.patch (text/plain), 4.63 KB, created by
Katrin Fischer
on 2017-08-16 08:46:12 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 19114 - Stored XSS in parcels.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-08-16 08:46:12 UTC
Size:
4.63 KB
patch
obsolete
>From 3e0ad5c711f1e3d4894a808b6d0aee546f2522dc Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Tue, 15 Aug 2017 20:58:34 +0530 >Subject: [PATCH] [SIGNED OFF] Bug 19114 - Stored XSS in parcels.pl > >Test >1. Hit the page /cgi-bin/koha/acqui/parcels.pl?booksellerid=xx > xx is booksellerid >2. Add a text in the field Vendor invoice that contains java script >3. Save the page. >4. Notice js is execute >5. Apply patch and reload the js is escaped > >Fixed XSS for parcels.pl/parcel.pl/orderreceive.pl > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 6 +++--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index b6e790c..b26343c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -125,7 +125,7 @@ > [% INCLUDE 'header.inc' %] > [% INCLUDE 'acquisitions-search.inc' %] > >-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> › <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid %]">[% name %]</a> › Receive items from : [% name %] [% IF ( invoice ) %][[% invoice %]][% END %] (order #[% ordernumber %])</div> >+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> › <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid %]">[% name %]</a> › Receive items from : [% name %] [% IF ( invoice ) %][[% invoice |html %]][% END %] (order #[% ordernumber %])</div> > > <div id="doc3" class="yui-t2"> > >@@ -133,7 +133,7 @@ > <div id="yui-main"> > <div class="yui-b"> > >-<h1>Receive items from : [% name %] [% IF ( invoice ) %][[% invoice %]] [% END %] (order #[% ordernumber %])</h1> >+<h1>Receive items from : [% name %] [% IF ( invoice ) %][[% invoice |html %]] [% END %] (order #[% ordernumber %])</h1> > > [% IF ( count ) %] > <form action="/cgi-bin/koha/acqui/finishreceive.pl" method="post" onsubmit="return Check(this);"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index a894cf4..1bb2c69 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -150,7 +150,7 @@ > [% IF datereceived %] > Receipt summary for <i>[% name %]</i> > [% IF ( invoice ) %] >- <i>[ [% invoice %] ]</i> >+ <i>[ [% invoice |html %] ]</i> > [% END %] > on <i>[% datereceived | $KohaDates %]</i> > [% ELSE %] >@@ -175,7 +175,7 @@ > [% END %] > <h1> > [% IF datereceived %] >- Receipt summary for <i>[% name %]</i> [% IF ( invoice ) %] <i> [ [% invoice %] ] </i>[% END %] on <i>[% datereceived | $KohaDates %]</i> >+ Receipt summary for <i>[% name %]</i> [% IF ( invoice ) %] <i> [ [% invoice |html %] ] </i>[% END %] on <i>[% datereceived | $KohaDates %]</i> > [% ELSE %] > Receive orders from [% name %] > [% END %] >@@ -218,7 +218,7 @@ > > [% UNLESS no_orders_to_display %] > <div id="acqui_receive_summary"> >-<p><strong>Invoice number:</strong> [% invoice %] <strong>Received by:</strong> [% loggedinusername %] <strong>On:</strong> [% datereceived | $KohaDates %]</p> >+<p><strong>Invoice number:</strong> [% invoice |html %] <strong>Received by:</strong> [% loggedinusername %] <strong>On:</strong> [% datereceived | $KohaDates %]</p> > </div> > [% UNLESS (invoiceclosedate) %] > <div id="acqui_receive_search"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >index 802533f..33e7a8d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >@@ -107,7 +107,7 @@ > </td> > <td> > [% IF ( searchresult.code ) %] >- <a href="/cgi-bin/koha/acqui/parcel.pl?invoiceid=[% searchresult.invoiceid %]">[% searchresult.code %]</a> >+ <a href="/cgi-bin/koha/acqui/parcel.pl?invoiceid=[% searchresult.invoiceid %]">[% searchresult.code |html %]</a> > [% ELSE %] > <abbr title="not available">n/a</abbr> > [% END %] >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19114
:
66021
|
66047
|
66066