Bugzilla – Attachment 66071 Details for
Bug 19102
XSS Flaws in circulation.pl - routing-lists.pl - readingrec.pl - notices.pl - maninvoice.pl - boraccount.pl - mancredit.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 19102 Fix XSS in readingrec.pl
SIGNED-OFF-Bug-19102-Fix-XSS-in-readingrecpl.patch (text/plain), 1.45 KB, created by
Katrin Fischer
on 2017-08-16 11:36:13 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 19102 Fix XSS in readingrec.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-08-16 11:36:13 UTC
Size:
1.45 KB
patch
obsolete
>From 902e9da96550d150910972f27f4cdde5bbc6bd45 Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Mon, 14 Aug 2017 22:27:03 +0530 >Subject: [PATCH] [SIGNED OFF] Bug 19102 Fix XSS in readingrec.pl > >1. Hit /cgi-bin/koha/members/readingrec.pl?borrowernumber=xx<script>alert('XSS Payload')</script> > xx is a borrowernumber >2. Notice java script is execute. >3. Apply patch. >4. Reload page, and hit the page again /cgi-bin/koha/members/readingrec.pl?borrowernumber=xx<script>alert('XSS Payload')</script> > xx is a borrowernumber >5. Notice it is no longer executed. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > members/readingrec.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/members/readingrec.pl b/members/readingrec.pl >index b0b563c..5a26851 100755 >--- a/members/readingrec.pl >+++ b/members/readingrec.pl >@@ -24,7 +24,7 @@ use strict; > use warnings; > > use CGI qw ( -utf8 ); >- >+use HTML::Entities; > use C4::Auth; > use C4::Output; > use C4::Members; >@@ -59,7 +59,7 @@ if ($input->param('cardnumber')) { > $borrowernumber = $data->{'borrowernumber'}; # we must define this as it is used to retrieve other data about the patron > } > if ($input->param('borrowernumber')) { >- $borrowernumber = $input->param('borrowernumber'); >+ $borrowernumber = HTML::Entities::encode($input->param('borrowernumber')); > $patron = Koha::Patrons->find( $borrowernumber ); > $data = $patron->unblessed; > } >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19102
:
65975
|
65976
|
65977
|
65978
|
65979
|
65980
|
65981
|
65982
|
65983
|
66069
|
66070
| 66071 |
66072
|
66073
|
66074
|
66075