Bugzilla – Attachment 66072 Details for
Bug 19102
XSS Flaws in circulation.pl - routing-lists.pl - readingrec.pl - notices.pl - maninvoice.pl - boraccount.pl - mancredit.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 19102 Fix XSS in notices.pl
SIGNED-OFF-Bug-19102-Fix-XSS-in-noticespl.patch (text/plain), 1.23 KB, created by
Katrin Fischer
on 2017-08-16 11:36:17 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 19102 Fix XSS in notices.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-08-16 11:36:17 UTC
Size:
1.23 KB
patch
obsolete
>From 08a5f6004fca8a248942fdf4a65900d624e29def Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Mon, 14 Aug 2017 22:30:46 +0530 >Subject: [PATCH] [SIGNED OFF] Bug 19102 Fix XSS in notices.pl > >1. Hit /cgi-bin/koha/members/notices.pl?borrowernumber=xx<script>alert('XSS Payload')</script> > xx is a borrowernumber >2. Notice java script is execute. >3. Apply patch. >4. Reload page, and hit the page again /cgi-bin/koha/members/notices.pl?borrowernumber=xx<script>alert('XSS Payload')</script> > xx is a borrowernumber >5. Notice it is no longer executed. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > members/notices.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/members/notices.pl b/members/notices.pl >index 977c921..6d7ef86 100755 >--- a/members/notices.pl >+++ b/members/notices.pl >@@ -22,6 +22,7 @@ > use strict; > #use warnings; FIXME - Bug 2505 > use C4::Auth; >+use HTML::Entities; > use C4::Output; > use CGI qw ( -utf8 ); > use C4::Members; >@@ -33,6 +34,7 @@ my $input=new CGI; > > > my $borrowernumber = $input->param('borrowernumber'); >+$borrowernumber = HTML::Entities::encode($borrowernumber); > my $patron = Koha::Patrons->find( $borrowernumber ); > my $borrower = $patron->unblessed; > >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19102
:
65975
|
65976
|
65977
|
65978
|
65979
|
65980
|
65981
|
65982
|
65983
|
66069
|
66070
|
66071
| 66072 |
66073
|
66074
|
66075