From d44c8d9cdc6221c50d30a0759657c82abf81a658 Mon Sep 17 00:00:00 2001
From: Amit Gupta <amit.gupta@informaticsglobal.com>
Date: Tue, 15 Aug 2017 13:55:45 +0530
Subject: [PATCH] [SIGNED OFF] Bug 19108 - Stored XSS in classsources.pl

Fixed for both Classification sources & Classification filing rules

To Test
1. first case classification source: Hit the page
   /cgi-bin/koha/admin/classsources.pl?op=add_source
   second case classification filing rules:
   Hit the page /cgi-bin/koha/admin/classsources.pl?op=add_sort_rule
2. Add a text in the field Description that contains js
3. Save the page.
4. Notice js is execute
5. Apply patch and reload, the js is escaped

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
index be817dc..314b51e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
@@ -213,7 +213,7 @@
   [% FOREACH class_source IN class_sources %]
   <tr>
     <td>[% class_source.code %]</td>
-    <td>[% class_source.description %]</td>
+    <td>[% class_source.description |html %]</td>
     <td>[% IF ( class_source.used ) %]Yes[% ELSE %]No[% END %]</td>
     <td>[% class_source.sortrule %]</td>
     <td class="actions">
@@ -247,7 +247,7 @@
   [% FOREACH class_sort_rule IN class_sort_rules %]
   <tr>
     <td>[% class_sort_rule.rule %]</td>
-    <td>[% class_sort_rule.description %]</td>
+    <td>[% class_sort_rule.description |html %]</td>
     <td>[% class_sort_rule.sort_routine %]</td>
     <td class="actions">
       <a class="btn btn-default btn-xs" href="[% class_sort_rule.script_name %]?op=edit_sort_rule&amp;sort_rule=[% class_sort_rule.rule |html %]"><i class="fa fa-pencil"></i> Edit</a>
-- 
2.7.4