From 067dd84e8df2e20673e83bca444900368f869716 Mon Sep 17 00:00:00 2001 From: Amit Gupta <amit.gupta@informaticsglobal.com> Date: Tue, 15 Aug 2017 14:06:47 +0530 Subject: [PATCH] [SIGNED OFF] Bug 19108 - Stored XSS in authtypes.pl To Test 1. Hit the page /cgi-bin/koha/admin/authtypes.pl?op=add_form 2. Add a text in the field Description that contains js 3. Save the page. 4. Notice js is execute 5. Apply patch and reload, the js is escaped Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt index f76f394..2f69f53 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt @@ -160,8 +160,8 @@ [% FOREACH authority_type IN authority_types %] <tr> <td>[% authority_type.authtypecode %]</td> - <td>[% authority_type.authtypetext %]</td> - <td>[% authority_type.summary %]</td> + <td>[% authority_type.authtypetext |html %]</td> + <td>[% authority_type.summary |html %]</td> <td>[% authority_type.auth_tag_to_report %]</td> <td> <div class="dropdown"> -- 2.7.4