From 30c5877e87e9a80df9f9c53552a5cd7bc3fedc17 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 20 Jul 2017 14:28:20 -0400
Subject: [PATCH] Bug 19135 - AllowHoldsOnPatronsPossessions not working
Test Plan:
1) Set AllowHoldsOnPatronsPossessions to "Don't"
2) Check out an item to a patron
3) Place a hold on that item for the same patron
4) Note you are allowed to with no alert
5) Delete the hold
6) Apply this patch
7) Place a hold on that item for the same patron
8) Note you recieve an alert now
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
---
reserve/request.pl | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/reserve/request.pl b/reserve/request.pl
index 7cda03d..565210e 100755
--- a/reserve/request.pl
+++ b/reserve/request.pl
@@ -266,15 +266,12 @@ foreach my $biblionumber (@biblionumbers) {
$template->param( max_holds_for_record => $max_holds_for_record );
$template->param( remaining_holds_for_record => $remaining_holds_for_record );
- { # alreadypossession
- # Check to see if patron is allowed to place holds on records where the
- # patron already has an item from that record checked out
- my $alreadypossession;
- if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions')
- && CheckIfIssuedToPatron( $patron->borrowernumber, $biblionumber ) )
- {
- $template->param( alreadypossession => $alreadypossession, );
- }
+ # Check to see if patron is allowed to place holds on records where the
+ # patron already has an item from that record checked out
+ if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions')
+ && CheckIfIssuedToPatron( $patron->borrowernumber, $biblionumber ) )
+ {
+ $template->param( alreadypossession => 1 );
}
}
--
2.10.2