Bugzilla – Attachment 66149 Details for
Bug 19135
AllowHoldsOnPatronsPossessions is not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 19135 - AllowHoldsOnPatronsPossessions not working
SIGNED-OFF-Bug-19135---AllowHoldsOnPatronsPossessi.patch (text/plain), 2.02 KB, created by
Christopher Brannon
on 2017-08-17 17:02:31 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 19135 - AllowHoldsOnPatronsPossessions not working
Filename:
MIME Type:
Creator:
Christopher Brannon
Created:
2017-08-17 17:02:31 UTC
Size:
2.02 KB
patch
obsolete
>From 7eb095703f54ca5b43864fe0ba2c1b65bb395dcd Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 20 Jul 2017 14:28:20 -0400 >Subject: [PATCH] [SIGNED OFF] Bug 19135 - AllowHoldsOnPatronsPossessions not > working > >Test Plan: >1) Set AllowHoldsOnPatronsPossessions to "Don't" >2) Check out an item to a patron >3) Place a hold on that item for the same patron >4) Note you are allowed to with no alert >5) Delete the hold >6) Apply this patch >7) Place a hold on that item for the same patron >8) Note you recieve an alert now > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> >--- > reserve/request.pl | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 7cda03d..565210e 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -266,15 +266,12 @@ foreach my $biblionumber (@biblionumbers) { > $template->param( max_holds_for_record => $max_holds_for_record ); > $template->param( remaining_holds_for_record => $remaining_holds_for_record ); > >- { # alreadypossession >- # Check to see if patron is allowed to place holds on records where the >- # patron already has an item from that record checked out >- my $alreadypossession; >- if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions') >- && CheckIfIssuedToPatron( $patron->borrowernumber, $biblionumber ) ) >- { >- $template->param( alreadypossession => $alreadypossession, ); >- } >+ # Check to see if patron is allowed to place holds on records where the >+ # patron already has an item from that record checked out >+ if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions') >+ && CheckIfIssuedToPatron( $patron->borrowernumber, $biblionumber ) ) >+ { >+ $template->param( alreadypossession => 1 ); > } > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19135
:
66148
|
66149
|
67684
|
67718