Bugzilla – Attachment 6615 Details for
Bug 7325
Editing a list generates errors in the log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Bug-7325-Editing-a-list-generates-errors-in-the-log.patch (text/plain), 1.28 KB, created by
Owen Leonard
on 2011-12-06 21:08:41 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-12-06 21:08:41 UTC
Size:
1.28 KB
patch
obsolete
>From 556a70620a6d742f0a6ed916046d8a372c656430 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 6 Dec 2011 16:03:31 -0500 >Subject: [PATCH] Bug 7325 - Editing a list generates errors in the log >Content-Type: text/plain; charset="utf-8" > >Checking for variables before trying to use them in >building the pagination menu >--- > C4/VirtualShelves/Page.pm | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm >index 18535a5..523527e 100644 >--- a/C4/VirtualShelves/Page.pm >+++ b/C4/VirtualShelves/Page.pm >@@ -367,9 +367,9 @@ sub shelfpage ($$$$$) { > $qhash{$_} = $query->param($_) if $query->param($_); > } > ( scalar keys %qhash ) and $url .= '?' . join '&', map { "$_=$qhash{$_}" } keys %qhash; >- if ( $shelfnumber ) { >+ if ( $shelfnumber && $totitems ) { > $template->param( pagination_bar => pagination_bar( $url, ( int( $totitems / $shelflimit ) ) + ( ( $totitems % $shelflimit ) > 0 ? 1 : 0 ), $itemoff, "itemoff" ) ); >- } else { >+ } elsif ( $totshelves ) { > $template->param( > pagination_bar => pagination_bar( $url, ( int( $totshelves / $shelveslimit ) ) + ( ( $totshelves % $shelveslimit ) > 0 ? 1 : 0 ), $shelfoff, "shelfoff" ) ); > } >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7325
:
6615
|
6735