Bugzilla – Attachment 66184 Details for
Bug 18996
SIP sets ok flag to true for refused checkin for data corruption
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18996 [QA Followup] - Fix some minor whitespace issues
Bug-18996-QA-Followup---Fix-some-minor-whitespace-.patch (text/plain), 2.31 KB, created by
Kyle M Hall
on 2017-08-18 15:07:16 UTC
(
hide
)
Description:
Bug 18996 [QA Followup] - Fix some minor whitespace issues
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2017-08-18 15:07:16 UTC
Size:
2.31 KB
patch
obsolete
>From f3952cebea77d7780da65534413ddf88b72dd6f5 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 18 Aug 2017 04:45:41 +0000 >Subject: [PATCH] Bug 18996 [QA Followup] - Fix some minor whitespace issues > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SIP/ILS/Item.pm | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm >index 4e5441f..84e7411 100644 >--- a/C4/SIP/ILS/Item.pm >+++ b/C4/SIP/ILS/Item.pm >@@ -72,14 +72,14 @@ use Koha::Items; > =cut > > sub new { >- my ($class, $item_id) = @_; >- my $type = ref($class) || $class; >+ my ($class, $item_id) = @_; >+ my $type = ref($class) || $class; > my $item = Koha::Items->find( { barcode => $item_id } ); > unless ( $item ) { >- syslog("LOG_DEBUG", "new ILS::Item('%s'): not found", $item_id); >- warn "new ILS::Item($item_id) : No item '$item_id'."; >+ syslog("LOG_DEBUG", "new ILS::Item('%s'): not found", $item_id); >+ warn "new ILS::Item($item_id) : No item '$item_id'."; > return; >- } >+ } > my $self = $item->unblessed; > $self->{ 'id' } = $item->barcode; # to SIP, the barcode IS the id. > $self->{permanent_location}= $item->homebranch; >@@ -90,7 +90,7 @@ sub new { > my $itemtype = Koha::Database->new()->schema()->resultset('Itemtype')->find( $it ); > $self->{sip_media_type} = $itemtype->sip_media_type() if $itemtype; > >- # check if its on issue and if so get the borrower >+ # check if its on issue and if so get the borrower > my $issue = Koha::Checkouts->find( { itemnumber => $item->itemnumber } ); > if ($issue) { > $self->{due_date} = dt_from_string( $issue->date_due, 'sql' )->truncate( to => 'minute' ); >@@ -102,10 +102,10 @@ sub new { > $self->{hold_queue} = $holds; > $self->{hold_shelf} = [( grep { defined $_->{found} and $_->{found} eq 'W' } @{$self->{hold_queue}} )]; > $self->{pending_queue} = [( grep {(! defined $_->{found}) or $_->{found} ne 'W' } @{$self->{hold_queue}} )]; >- bless $self, $type; >+ bless $self, $type; > >- syslog("LOG_DEBUG", "new ILS::Item('%s'): found with title '%s'", >- $item_id, $self->{title}//'' ); >+ syslog( "LOG_DEBUG", "new ILS::Item('%s'): found with title '%s'", >+ $item_id, $self->{title} // '' ); > > return $self; > } >-- >2.10.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18996
:
65303
|
65304
|
65330
|
65336
|
65393
|
65394
|
65418
|
65961
|
65962
|
65963
|
65964
|
66180
|
66181
|
66182
|
66183
| 66184 |
67055
|
67056
|
67057
|
67058
|
67059
|
67849