Bugzilla – Attachment 66305 Details for
Bug 19157
XSS Stored in letter.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19157 - XSS Stored in letter.pl
Bug-19157---XSS-Stored-in-letterpl.patch (text/plain), 2.04 KB, created by
Alex Buckley
on 2017-08-22 06:01:39 UTC
(
hide
)
Description:
Bug 19157 - XSS Stored in letter.pl
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-08-22 06:01:39 UTC
Size:
2.04 KB
patch
obsolete
>From 13f118bb766dee3dea75a65f0c6756448b11398d Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@informaticsglobal.com> >Date: Sun, 20 Aug 2017 21:08:42 +0530 >Subject: [PATCH] Bug 19157 - XSS Stored in letter.pl > >To Test > >1. Hit the page /cgi-bin/koha/tools/letter.pl?searchfield=&branchcode=*&op=add_form >2. Add a text in the field Name that contains java script >3. Save the page >4. Notice js is execute >5. Apply patch, reload, js is escaped. > >Fixed for Delete notice also. > >Followed test plan entering <script>alert("hello")</script> into the name field and behaviour works as described > >Also passes QA test tool > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >index 09a5e79..4c9a7f0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >@@ -228,7 +228,7 @@ $(document).ready(function() { > <td>[% IF lette.branchname %][% lette.branchname %][% ELSE %](All libraries)[% END %]</td> > <td>[% lette.module %]</td> > <td>[% lette.code %]</td> >- <td>[% lette.name %]</td> >+ <td>[% lette.name | html %]</td> > <td class="actions"> > [% IF !independant_branch || !lette.branchcode %] > <form method="post" action="/cgi-bin/koha/tools/letter.pl"> >@@ -523,7 +523,7 @@ $(document).ready(function() { > <td>[% IF letter.branchcode %][% Branches.GetName( letter.branchcode ) %][% ELSE %](All libraries)[% END %]</td> > <td>[% letter.module %]</td> > <td>[% letter.code %]</td> >- <td>[% letter.name %]</td> >+ <td>[% letter.name |html %]</td> > </tr> > </table> > <form action="[% action %]" method="post"> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19157
:
66244
|
66305
|
66452