From a1841e621cf47c53b3b53c6b7a8b6087e64996f9 Mon Sep 17 00:00:00 2001 From: Amit Gupta Date: Tue, 15 Aug 2017 13:49:10 +0530 Subject: [PATCH] Bug 19108 - Stored XSS in items_search_fields.pl Content-Type: text/plain; charset=utf-8 To Test 1. Hit the page /cgi-bin/koha/admin/items_search_fields.pl 2. Add a text in the field Name and Label that contains js 3. Save the page. 4. Notice js is execute 5. Apply patch and reload, the js is escaped Fixed for new and edit page Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy --- .../prog/en/includes/admin-items-search-field-form.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_field.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/admin/items_search_fields.tt | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc index a55f6c3..4ab91b1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc @@ -3,7 +3,7 @@
  • [% IF field %] Name: - [% field.name %] + [% field.name |html %] [% ELSE %] @@ -14,7 +14,7 @@
  • [% IF field %] - + [% ELSE %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_field.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_field.tt index cd29b2f..06fcd06 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_field.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_field.tt @@ -10,14 +10,14 @@ HomeAdministrationItem search fields › - [% field.name %] + [% field.name |html %]
    -

    Item search field: [% field.label %]

    +

    Item search field: [% field.label |html %]

    diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt index eb67749..0904553 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt @@ -27,7 +27,7 @@ [% IF field_added %]
    - Field successfully added: [% field_added.label %] + Field successfully added: [% field_added.label |html %]
    [% ELSIF field_not_added %]
    @@ -71,8 +71,8 @@ [% FOREACH field IN fields %] - [% field.name %] - [% field.label %] + [% field.name |html %] + [% field.label |html %] [% field.tagfield %] [% field.tagsubfield %] [% field.authorised_values_category %] -- 2.1.4