From 1d1e8d592773c4e1f24ef420eb7e777a2b8b3e5f Mon Sep 17 00:00:00 2001 From: Amit Gupta <amit.gupta@informaticsglobal.com> Date: Tue, 15 Aug 2017 14:10:43 +0530 Subject: [PATCH] Bug 19108 - Stored XSS in fieldmapping.pl Content-Type: text/plain; charset=utf-8 To Test 1. Hit the page /cgi-bin/koha/admin/fieldmapping.pl 2. Add a text in the field Field name that contains js 3. Save the page. 4. Notice js is execute 5. Apply patch and reload, the js is escaped Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt index d182750..238555a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt @@ -69,7 +69,7 @@ $(document).ready(function() { </tr> [% FOREACH field IN fields %] <tr> - <td>[% field.field %]</td> + <td>[% field.field |html %]</td> <td>[% field.fieldcode %]</td> <td>[% field.subfieldcode %]</td> <td><a class="btn btn-default btn-xs" href="?op=delete&id=[% field.id %]&framework=[% field.frameworkcode %]"><i class="fa fa-trash"></i> Delete</a></td> -- 2.1.4