From 73941ee9297da405d86c2fcddc78bc87740f42b2 Mon Sep 17 00:00:00 2001 From: Amit Gupta Date: Sun, 20 Aug 2017 21:08:42 +0530 Subject: [PATCH] Bug 19157 - XSS Stored in letter.pl Content-Type: text/plain; charset=utf-8 To Test 1. Hit the page /cgi-bin/koha/tools/letter.pl?searchfield=&branchcode=*&op=add_form 2. Add a text in the field Name that contains java script 3. Save the page 4. Notice js is execute 5. Apply patch, reload, js is escaped. Fixed for Delete notice also. Followed test plan entering into the name field and behaviour works as described Also passes QA test tool Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt index 09a5e79..4c9a7f0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt @@ -228,7 +228,7 @@ $(document).ready(function() { [% IF lette.branchname %][% lette.branchname %][% ELSE %](All libraries)[% END %] [% lette.module %] [% lette.code %] - [% lette.name %] + [% lette.name | html %] [% IF !independant_branch || !lette.branchcode %]
@@ -523,7 +523,7 @@ $(document).ready(function() { [% IF letter.branchcode %][% Branches.GetName( letter.branchcode ) %][% ELSE %](All libraries)[% END %] [% letter.module %] [% letter.code %] - [% letter.name %] + [% letter.name |html %] -- 2.1.4