Bugzilla – Attachment 66542 Details for
Bug 14385
Extend OpacHiddenItems to allow specifying exempt borrower categories
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14385: Improve C4::Record::marcrecord2csv test cases
SIGNED-OFF-Bug-14385-Improve-C4Recordmarcrecord2cs.patch (text/plain), 1.51 KB, created by
Aleisha Amohia
on 2017-08-27 23:44:07 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14385: Improve C4::Record::marcrecord2csv test cases
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2017-08-27 23:44:07 UTC
Size:
1.51 KB
patch
obsolete
>From 01aa46e37f67c3509a4d1bc7cb287f239f1e6136 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 22 Aug 2017 16:45:30 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 14385: Improve C4::Record::marcrecord2csv > test cases > >Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> >--- > t/db_dependent/Record/marcrecord2csv.t | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Record/marcrecord2csv.t b/t/db_dependent/Record/marcrecord2csv.t >index e5cf0d3..025e8c3 100644 >--- a/t/db_dependent/Record/marcrecord2csv.t >+++ b/t/db_dependent/Record/marcrecord2csv.t >@@ -1,7 +1,7 @@ > #!/usr/bin/perl; > > use Modern::Perl; >-use Test::More tests => 11; >+use Test::More tests => 12; > use Test::MockModule; > use MARC::Record; > use MARC::Field; >@@ -29,7 +29,11 @@ my $csv_content = q(Title=245$a|Author=245$c|Subject=650$a); > my $csv_profile_id_1 = insert_csv_profile({ csv_content => $csv_content }); > my $csv = Text::CSV::Encoded->new(); > >-my $csv_output = C4::Record::marcrecord2csv( $biblionumber, $csv_profile_id_1, 1, $csv ); >+# Test bad biblionumber case >+my $csv_output = C4::Record::marcrecord2csv( -1, $csv_profile_id_1, 1, $csv ); >+ok (! defined $csv_output, 'Bad biblionumber gives undef as expected.'); >+ >+$csv_output = C4::Record::marcrecord2csv( $biblionumber, $csv_profile_id_1, 1, $csv ); > > is( $csv_output, q[Title|Author|Subject > "The art of computer programming,The art of another title"|"Donald E. Knuth.,Donald E. Knuth. II"|"Computer programming.,Computer algorithms." >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14385
:
40158
|
53483
|
53494
|
53505
|
53506
|
53507
|
55593
|
64688
|
64689
|
64690
|
64691
|
64692
|
64693
|
65322
|
65323
|
65324
|
65325
|
65376
|
65377
|
65378
|
65379
|
65380
|
65381
|
65382
|
65383
|
65384
|
65385
|
65386
|
65387
|
65388
|
65389
|
65408
|
65409
|
65410
|
65411
|
66103
|
66104
|
66105
|
66106
|
66107
|
66108
|
66109
|
66110
|
66111
|
66112
|
66113
|
66114
|
66115
|
66116
|
66117
|
66118
|
66125
|
66126
|
66127
|
66128
|
66129
|
66130
|
66131
|
66132
|
66192
|
66193
|
66194
|
66195
|
66196
|
66197
|
66198
|
66199
|
66200
|
66201
|
66202
|
66203
|
66204
|
66205
|
66206
|
66207
|
66208
|
66209
|
66210
|
66302
|
66303
|
66347
|
66361
|
66372
|
66401
|
66403
|
66520
|
66521
|
66522
|
66523
|
66524
|
66525
|
66526
|
66527
|
66528
|
66529
|
66530
|
66531
|
66532
|
66533
|
66534
|
66535
|
66536
|
66537
|
66538
|
66539
|
66540
|
66541
|
66542
|
66543
|
66544
|
66545
|
70256
|
70257
|
70258
|
70259
|
72445
|
72446
|
72447
|
72448
|
72449
|
72450
|
72451
|
72452
|
72453
|
72454
|
74001
|
78654
|
78655
|
78656
|
78657
|
78825
|
78826
|
78827
|
78828
|
80411
|
80463
|
80464
|
80465
|
80466
|
80467
|
89963
|
90038