Bugzilla – Attachment 66644 Details for
Bug 18780
Translatability: Get rid of exposed tt directive in masthead-langmenu.inc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc
Bug-18780-Translatability-Get-rid-of-exposed-tt-di.patch (text/plain), 2.12 KB, created by
Jonathan Druart
on 2017-08-30 19:39:15 UTC
(
hide
)
Description:
Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-08-30 19:39:15 UTC
Size:
2.12 KB
patch
obsolete
>From 4c6e14a3cb6823e980cc101560236acd325a905f Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Mon, 12 Jun 2017 08:41:41 +0200 >Subject: [PATCH] Bug 18780: Translatability: Get rid of exposed tt directive > in masthead-langmenu.inc > >The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators: > >"[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && " >"( languages_loop ) && ( OpacLangSelectorMode == 'both' || " >"OpacLangSelectorMode == 'top') ) %%] " > >This patch fixes it. > >To test: >- Apply patch >- Verify that language selector in OPAC (top of the page) works as expected >- Bonus test: create a new language 'aa-AA', verify that line above does not >show up in aa-AA-opac-bootstrap.po > >NOTE: Followed a test plan similar to bug 18776 comment 3 > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc >index 9c87eae30d..a5f8aa2359 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc >@@ -1,9 +1,5 @@ >- >-[% IF ( ( opaclanguagesdisplay ) && >- ( ! one_language_enabled ) && >- ( languages_loop ) && >- ( OpacLangSelectorMode == 'both' || OpacLangSelectorMode == 'top') ) >-%] >+[%# Following on one line for translatability %] >+[% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && ( languages_loop ) && ( OpacLangSelectorMode == 'both' || OpacLangSelectorMode == 'top') ) %] > <li class="dropdown"> > <a href="#" title="Switch languages" class="dropdown-toggle" id="langmenu" data-toggle="dropdown" role="button"><i class="icon-flag icon-white"></i> <span class="langlabel">Languages</span> <b class="caret"></b></a> > <ul aria-labelledby="langmenu" role="menu" class="dropdown-menu"> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18780
:
64191
|
64737
| 66644