From efdb0d0a799c6a49e0cd507ff798e6fb8ac94c7b Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 30 Aug 2017 10:35:03 -0400 Subject: [PATCH] Bug 19208 [Master] - Pay select option doesn't pay the selected fine MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended. The fine on top of the list gets the amount deducted, even if another fine is choosen from the list. Test Plan: 1) Create two or three fines, using the Create manual invoice function. 2) Choose one of the fines (not the one on the top) and click Pay selected 3) Pay a partial amount 4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected. 5) Apply this patch 6) Repeat steps 1-3 7) Note the correct fine is paid Signed-off-by: Andreas Hedström Mace --- koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 2 -- members/paycollect.pl | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt index 1e317bc..a1458b5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ -110,7 +110,6 @@ function moneyFormat(textObj) { - @@ -167,7 +166,6 @@ function moneyFormat(textObj) { - diff --git a/members/paycollect.pl b/members/paycollect.pl index 3576d10..5d959c5 100755 --- a/members/paycollect.pl +++ b/members/paycollect.pl @@ -70,7 +70,6 @@ my $writeoff = $input->param('writeoff_individual'); my $select_lines = $input->param('selected'); my $select = $input->param('selected_accts'); my $payment_note = uri_unescape $input->param('payment_note'); -my $accountno; my $accountlines_id; if ( $individual || $writeoff ) { @@ -83,7 +82,6 @@ if ( $individual || $writeoff ) { $accountlines_id = $input->param('accountlines_id'); my $amount = $input->param('amount'); my $amountoutstanding = $input->param('amountoutstanding'); - $accountno = $input->param('accountno'); my $itemnumber = $input->param('itemnumber'); my $description = $input->param('description'); my $title = $input->param('title'); @@ -93,7 +91,6 @@ if ( $individual || $writeoff ) { $template->param( accounttype => $accounttype, accountlines_id => $accountlines_id, - accountno => $accountno, amount => $amount, amountoutstanding => $amountoutstanding, title => $title, @@ -143,7 +140,7 @@ if ( $total_paid and $total_paid ne '0.00' ) { { borrowernumber => $borrowernumber, amountoutstanding => { '<>' => 0 }, - accountno => { 'IN' => \@acc }, + accountlines_id => { 'IN' => \@acc }, }, { order_by => 'date' } ); -- 2.1.4