From 810d9940b328a46fba4a38a9e93947bd7f397caf Mon Sep 17 00:00:00 2001
From: Katrin Fischer <Katrin.Fischer.83@web.de>
Date: Fri, 4 Dec 2015 01:17:50 +0100
Subject: [PATCH] Bug 9857: Did you mean? uses wrong punctuation in search
links
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The link changes the search links generated by the plugins
from an=authid to an:authid, as suggested by Jared on the
bug report.
- Turn on the AuthorityFile und ExplodedTerms plugins
for the OPAC from the "Did you mean" section of the
administration module
- Search a term in your OPAC where one or several
authorities exist.
A last name or a place name might work well.
- Verify that there are suggestions displayed on top of
your result list.
- Verify that the link created is something like:
/cgi-bin/koha/opac-search.pl?q=an=14084
- Apply patch.
- Verify the link has changed a little and still works
correctly:
/cgi-bin/koha/opac-search.pl?q=an:14084
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
Koha/SuggestionEngine/Plugin/AuthorityFile.pm | 2 +-
Koha/SuggestionEngine/Plugin/ExplodedTerms.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Koha/SuggestionEngine/Plugin/AuthorityFile.pm b/Koha/SuggestionEngine/Plugin/AuthorityFile.pm
index 1030344..fad0a58 100644
--- a/Koha/SuggestionEngine/Plugin/AuthorityFile.pm
+++ b/Koha/SuggestionEngine/Plugin/AuthorityFile.pm
@@ -94,7 +94,7 @@ sub get_suggestions {
foreach my $auth (@$searchresults) {
push @results,
{
- 'search' => "an=$auth->{'authid'}",
+ 'search' => "an:$auth->{'authid'}",
relevance => $count--,
label => $auth->{summary}->{authorized}->[0]->{heading}
};
diff --git a/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm b/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm
index 009f2ec..c8a3339 100644
--- a/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm
+++ b/Koha/SuggestionEngine/Plugin/ExplodedTerms.pm
@@ -85,7 +85,7 @@ sub get_suggestions {
my @results;
foreach my $index (@indexes) {
my $thissearch = $search;
- $thissearch = "$index=$thissearch"
+ $thissearch = "$index:$thissearch"
unless ( $thissearch =~ s/OP!/$index=/g );
$template->{VARS}->{index} = $index;
my $label = $template->output;
--
2.10.2