Bugzilla – Attachment 66973 Details for
Bug 18956
Possible privacy breach with OPAC password recovery
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18956: [QA Follow-up] Resolve a CGI::Param in list context warn
Bug-18956-QA-Follow-up-Resolve-a-CGIParam-in-list-.patch (text/plain), 1.43 KB, created by
Marcel de Rooy
on 2017-09-08 06:56:38 UTC
(
hide
)
Description:
Bug 18956: [QA Follow-up] Resolve a CGI::Param in list context warn
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-09-08 06:56:38 UTC
Size:
1.43 KB
patch
obsolete
>From fa645424e17ed7073e026ec00b4a9c75fe9d9c25 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 8 Sep 2017 08:53:37 +0200 >Subject: [PATCH] Bug 18956: [QA Follow-up] Resolve a CGI::Param in list > context warn >Content-Type: text/plain; charset=utf-8 > >From the plack-error.log: >CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_masterclone_opac_opac_2dpassword_2drecovery_2epl line 129, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-password-recovery.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-password-recovery.pl b/opac/opac-password-recovery.pl >index c8b2c06..e0416bc 100755 >--- a/opac/opac-password-recovery.pl >+++ b/opac/opac-password-recovery.pl >@@ -126,7 +126,7 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) { > username => $username > ); > } >- elsif ( SendPasswordRecoveryEmail( $borrower, $email, $query->param('resendEmail') ) ) { # generate uuid and send recovery email >+ elsif ( SendPasswordRecoveryEmail( $borrower, $email, scalar $query->param('resendEmail') ) ) { # generate uuid and send recovery email > $template->param( > mail_sent => 1, > email => $email >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18956
:
65105
|
66026
|
66221
|
66222
|
66491
|
66492
|
66972
| 66973 |
67107
|
67952