Bugzilla – Attachment 67059 Details for
Bug 18996
SIP sets ok flag to true for refused checkin for data corruption
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18996: [16.11.x] use Koha::OldIssues instead of Koha::Old::Checkouts
Bug-18996-1611x-use-KohaOldIssues-instead-of-KohaO.patch (text/plain), 1.65 KB, created by
Jonathan Druart
on 2017-09-11 19:11:16 UTC
(
hide
)
Description:
Bug 18996: [16.11.x] use Koha::OldIssues instead of Koha::Old::Checkouts
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-09-11 19:11:16 UTC
Size:
1.65 KB
patch
obsolete
>From a8d9dbdfd088b1eacc65e76eb1777fe89f9b40d7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 11 Sep 2017 16:08:41 -0300 >Subject: [PATCH] Bug 18996: [16.11.x] use Koha::OldIssues instead of > Koha::Old::Checkouts > >--- > t/db_dependent/SIP/Message.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/SIP/Message.t b/t/db_dependent/SIP/Message.t >index 6c44db29a7..84bc7cc330 100755 >--- a/t/db_dependent/SIP/Message.t >+++ b/t/db_dependent/SIP/Message.t >@@ -34,7 +34,7 @@ use Koha::AuthUtils qw(hash_password); > use Koha::DateUtils; > use Koha::Items; > use Koha::Checkouts; >-use Koha::Old::Checkouts; >+use Koha::OldIssues; > use Koha::Patrons; > > use C4::SIP::ILS; >@@ -309,7 +309,7 @@ sub test_checkin_v2 { > t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' ); > > # Data corrupted: add same issue_id to old_issues >- Koha::Old::Checkout->new({ issue_id => $issue->issue_id })->store; >+ Koha::OldIssue->new({ issue_id => $issue->issue_id })->store; > undef $response; > $msg = C4::SIP::Sip::MsgType->new( $siprequest, 0 ); > warnings_like { $msg->handle_checkin( $server ); } >@@ -320,7 +320,7 @@ sub test_checkin_v2 { > check_field( $respcode, $response, FID_SCREEN_MSG, 'Checkin failed: data problem', 'Check screen msg' ); > > # Finally checkin without problems (remove duplicate id) >- Koha::Old::Checkouts->search({ issue_id => $issue->issue_id })->delete; >+ Koha::OldIssues->search({ issue_id => $issue->issue_id })->delete; > undef $response; > $msg = C4::SIP::Sip::MsgType->new( $siprequest, 0 ); > $msg->handle_checkin( $server ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18996
:
65303
|
65304
|
65330
|
65336
|
65393
|
65394
|
65418
|
65961
|
65962
|
65963
|
65964
|
66180
|
66181
|
66182
|
66183
|
66184
|
67055
|
67056
|
67057
|
67058
| 67059 |
67849