From 17fac5ccc2e4adf52dd131f77b65623af9b8b4c2 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 28 Sep 2016 11:04:23 +0100
Subject: [PATCH] Bug 17282: Remove use of onclick

---
 koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc                    | 2 +-
 .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt     | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
index 1d69a6f..c0fa2a6 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
@@ -37,7 +37,7 @@
                     <fieldset class="chart-column-conf" id="column_[% column %]" style="display: inline !important;">
                         <legend>
                             Column [% column %]
-                            <a class="chart-column-delete" href="#" onclick="removeColumn('column_[% column %]'); return false;">
+                            <a class="chart-column-delete" href="#" data-column="[% column %]">
                                 <img src="[% interface %]/[% theme %]/img/x.png" alt="Delete" />
                             </a>
                         </legend>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
index 71489bd..f415be0 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ -935,6 +935,10 @@ canned reports and writing custom SQL reports.</p>
             $('.chart-column-delete').remove();
         }
 
+        $(".chart-column-delete").on('click', function(e){
+            e.preventDefault();
+            removeColumn('column_' + $(this).data('column'));
+        })
 
         $('#download-chart').click(function() {
             var svg = '<svg>' + $('#chart svg').html() + '</svg>';
-- 
2.7.4