Bugzilla – Attachment 67401 Details for
Bug 19374
CircSidebar overlapping transferred items table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19374: CircSidebar overlapping transferred items table
Bug-19374-CircSidebar-overlapping-transferred-item.patch (text/plain), 2.17 KB, created by
Jonathan Druart
on 2017-09-27 16:22:31 UTC
(
hide
)
Description:
Bug 19374: CircSidebar overlapping transferred items table
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-09-27 16:22:31 UTC
Size:
2.17 KB
patch
obsolete
>From 47fa25d3f28c270bb4c70cb39382269e2c88d3c3 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@jns.fi> >Date: Wed, 27 Sep 2017 17:59:55 +0300 >Subject: [PATCH] Bug 19374: CircSidebar overlapping transferred items table > >When CircSidebar is activated, "Transferred items" table at >Circulation -> Transfers goes under the sidebar. This patch fixes the issue. > >To test: >1. Enable CircSidebar system preference >2. Go to cgi-bin/koha/circ/branchtransfers.pl >3. Enter a barcode and click submit >4. Observe transferred items table under the circulation side bar >5. Apply patch >6. Enter a barcode and click submit >7. Observe transferred items is now correctly displayed >8. Also test with CircSidebar system preference deactivated > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Bug 19374: (follow-up) Remove stray closing div tag > >To test: >1. Apply first patch and validate the document e.g. here > https://validator.w3.org/#validate_by_input >2. Observe "Stray end tag div." error >3. Apply this patch and validate again >4. Observe no errors >5. Go through test plan from first patch to make sure things still look nice > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >index d1a3be5bcd..3fc491cf2d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >@@ -162,7 +162,7 @@ > <input type="hidden" name="fb-[% trsfitemloo.counter %]" value="[% trsfitemloo.frombrcd %]" /> > <input type="hidden" name="tb-[% trsfitemloo.counter %]" value="[% trsfitemloo.tobrcd %]" /> > [% END %] >- </form></div> >+ </form> > </div> > > [% IF ( trsfitemloop ) %] >@@ -199,10 +199,10 @@ > [% END %] > </div> > [% IF Koha.Preference('CircSidebar') %] >+</div> > <div class="yui-b noprint"> > [% INCLUDE 'circ-nav.inc' %] > </div> > [% END %] > </div> >-</div> > [% INCLUDE 'intranet-bottom.inc' %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19374
:
67395
|
67396
|
67397
|
67399
|
67401
|
67681