Bugzilla – Attachment 67718 Details for
Bug 19135
AllowHoldsOnPatronsPossessions is not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19135: Restore AllowHoldsOnPatronsPossessions behaviour
Bug-19135-Restore-AllowHoldsOnPatronsPossessions-b.patch (text/plain), 1.69 KB, created by
Jonathan Druart
on 2017-10-06 14:39:24 UTC
(
hide
)
Description:
Bug 19135: Restore AllowHoldsOnPatronsPossessions behaviour
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-10-06 14:39:24 UTC
Size:
1.69 KB
patch
obsolete
>From 78b001be78579bb4186d3b73ce56e8f96dc83627 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 20 Jul 2017 14:28:20 -0400 >Subject: [PATCH] Bug 19135: Restore AllowHoldsOnPatronsPossessions behaviour > >Bug caused by > commit bc39f0392bbebaad4c083f81308f652a325be042 > Bug 14695 - Add ability to place multiple item holds on a given record per patron > >Test Plan: >1) Set AllowHoldsOnPatronsPossessions to "Don't" >2) Check out an item to a patron >3) Place a hold on that item for the same patron >4) Note you are allowed to with no alert >5) Delete the hold >6) Apply this patch >7) Place a hold on that item for the same patron >8) Note you recieve an alert now > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > reserve/request.pl | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 3930e2714d..f4cdc16fa7 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -269,11 +269,10 @@ foreach my $biblionumber (@biblionumbers) { > { # alreadypossession > # Check to see if patron is allowed to place holds on records where the > # patron already has an item from that record checked out >- my $alreadypossession; > if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions') > && CheckIfIssuedToPatron( $patron->borrowernumber, $biblionumber ) ) > { >- $template->param( alreadypossession => $alreadypossession, ); >+ $template->param( alreadypossession => 1, ); > } > } > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19135
:
66148
|
66149
|
67684
| 67718