From 42eba42f81b04ac120ef81b68840a612fd448f55 Mon Sep 17 00:00:00 2001 From: David Cook Date: Tue, 26 Sep 2017 11:45:25 +1000 Subject: [PATCH] Bug 19367 - $biblio variable redefined in same scope in ISBDdetail The following warning is generated by ISBDdetail.pl: my" variable $biblio masks earlier declaration in same scope at ./catalogue/ISBDdetail.pl line 171. This patch removes this unnecessary declaration, which removes the warning. _TEST PLAN_ After applying patch: 1) Check code compilation with "KOHA_CONF=/path/to/koha-conf.xml perl -c catalogue/ISBDdetail.pl" 2) Note the only message is "./catalogue/ISBDdetail.pl syntax OK" 2) On /cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=1, view the source of the page and verify that the Javascript contains a holdcount e.g. "var holdcount = 0". Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens --- catalogue/ISBDdetail.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/catalogue/ISBDdetail.pl b/catalogue/ISBDdetail.pl index f58e1a9..27cb699 100755 --- a/catalogue/ISBDdetail.pl +++ b/catalogue/ISBDdetail.pl @@ -170,7 +170,6 @@ $template->param (countorders => $count_orders_using_biblio); my $count_deletedorders_using_biblio = scalar @deletedorders_using_biblio ; $template->param (countdeletedorders => $count_deletedorders_using_biblio); -my $biblio = Koha::Biblios->find( $biblionumber ); my $holds = $biblio->holds; $template->param( holdcount => $holds->count ); -- 2.1.4