From b541932e176addd7e58972e2f4efdcdfac3ff589 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 10 Oct 2017 12:18:10 -0300 Subject: [PATCH] Bug 18961: Use exact match for select filters on item search MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The SQL operator LIKE is always used for filters when searching for items. If the filter is a select, we should search for an exact match. That way we avoid problematic search like "%NFIC%" and "%FIC%" (one includes the other one). Test plan: - Make sure you have collection codes 'Fiction' and 'Non-fiction' - Do an item search - Filter column 'Collection', select 'Fiction' - Result: Column contains items from Fiction only Followed test plan, works as expected. Signed-off-by: Marc VĂ©ron --- catalogue/itemsearch.pl | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/catalogue/itemsearch.pl b/catalogue/itemsearch.pl index c48f2f1..369142e 100755 --- a/catalogue/itemsearch.pl +++ b/catalogue/itemsearch.pl @@ -61,9 +61,15 @@ if (defined $format and $format eq 'json') { my @words = split /\s+/, $sSearch; foreach my $word (@words) { push @f, $columns[$i]; - push @q, "%$word%"; - push @op, 'like'; push @c, 'and'; + + if ( grep /^$columns[$i]$/, qw( ccode homebranch holdingbranch location notforloan ) ) { + push @q, "$word"; + push @op, '='; + } else { + push @q, "%$word%"; + push @op, 'like'; + } } } } -- 2.1.4