Bugzilla – Attachment 67952 Details for
Bug 18956
Possible privacy breach with OPAC password recovery
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18956: Fix empty to in message queue
Bug-18956-Fix-empty-to-in-message-queue.patch (text/plain), 2.21 KB, created by
Marcel de Rooy
on 2017-10-11 12:20:13 UTC
(
hide
)
Description:
Bug 18956: Fix empty to in message queue
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-10-11 12:20:13 UTC
Size:
2.21 KB
patch
obsolete
>From f349dc6c3bf5f421ae22cb67ec377177bf2c25af Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 13 Sep 2017 03:44:19 +0000 >Subject: [PATCH] Bug 18956: Fix empty to in message queue >Content-Type: text/plain; charset=utf-8 > >Follow the test plan in comment #20. >Also tweaked string, because it was really 'or' before too. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Amended text in added comment. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt | 2 +- > opac/opac-password-recovery.pl | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >index b16a33b..5c13952 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >@@ -86,7 +86,7 @@ > <form action="/cgi-bin/koha/opac-password-recovery.pl" method="post" autocomplete="off"> > <input type="hidden" name="koha_login_context" value="opac" /> > <fieldset> >- <p>To reset your password, enter your login and your email address. >+ <p>To reset your password, enter your login or your email address. > <label for="username">Login:</label> > <input type="text" id="username" size="40" name="username" value="[% username %]" /> > <label for="email">Email:</label> >diff --git a/opac/opac-password-recovery.pl b/opac/opac-password-recovery.pl >index cc2717d..159f7f4 100755 >--- a/opac/opac-password-recovery.pl >+++ b/opac/opac-password-recovery.pl >@@ -107,6 +107,10 @@ if ( $query->param('sendEmail') || $query->param('resendEmail') ) { > DeleteExpiredPasswordRecovery( $borrower->borrowernumber ); > } > } >+ # Set the $email, if we don't have one. >+ if ( !$hasError && !$email ) { >+ $email = $firstNonEmptyEmail; >+ } > } > else { # 0 matching borrower > $hasError = 1; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18956
:
65105
|
66026
|
66221
|
66222
|
66491
|
66492
|
66972
|
66973
|
67107
| 67952