Bugzilla – Attachment 67994 Details for
Bug 19260
Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[17.05] Bug 19260: [QA Follow-up] Remove obsolete $dbh
1705-Bug-19260-QA-Follow-up-Remove-obsolete-dbh.patch (text/plain), 1.14 KB, created by
Josef Moravec
on 2017-10-12 12:10:19 UTC
(
hide
)
Description:
[17.05] Bug 19260: [QA Follow-up] Remove obsolete $dbh
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-10-12 12:10:19 UTC
Size:
1.14 KB
patch
obsolete
>From 810594f010542476774b35dc1fa1094d28e907e3 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 6 Oct 2017 11:05:49 +0200 >Subject: [PATCH] [17.05] Bug 19260: [QA Follow-up] Remove obsolete $dbh > >The variable is no longer used. >Removed a few empty lines on the way. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Reserves.pm | 5 ----- > 1 file changed, 5 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index be144d2..d763937 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -876,17 +876,12 @@ Cancels all reserves with an expiration date from before today. > =cut > > sub CancelExpiredReserves { >- > my $today = dt_from_string(); > my $cancel_on_holidays = C4::Context->preference('ExpireReservesOnHolidays'); > my $expireWaiting = C4::Context->preference('ExpireReservesMaxPickUpDelay'); > >- my $dbh = C4::Context->dbh; >- > my $dtf = Koha::Database->new->schema->storage->datetime_parser; >- > my $params = { expirationdate => { '<', $dtf->format_date($today) } }; >- > $params->{found} = undef unless $expireWaiting; > > # FIXME To move to Koha::Holds->search_expired (?) >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19260
:
67428
|
67489
|
67653
|
67654
|
67659
|
67660
|
67677
|
67678
|
67679
|
67680
|
67733
|
67992
|
67993
| 67994 |
67995