Bugzilla – Attachment 68145 Details for
Bug 17492
Show warning if patron's age is out of category limits
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17509: Removed invalid patterns
Bug-17509-Removed-invalid-patterns.patch (text/plain), 3.84 KB, created by
Katrin Fischer
on 2017-10-14 20:41:57 UTC
(
hide
)
Description:
Bug 17509: Removed invalid patterns
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-10-14 20:41:57 UTC
Size:
3.84 KB
patch
obsolete
>From 0141675ab497ed97622d9cc34e5666b483127337 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Radek=20=C5=A0iman?= <rbit@rbit.cz> >Date: Tue, 10 Oct 2017 11:55:32 +0200 >Subject: [PATCH] Bug 17509: Removed invalid patterns > >This patch only removes invalid gender-specific patterns from messages >in automated tests. > >https://bugs.koha-community.org/show_bug.cgi?id=17492 > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/db_dependent/Koha/Patrons.t | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index 35b5d36..03b78ed 100644 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -559,31 +559,31 @@ subtest 'is_category_valid' => sub { > is( $patron->is_category_valid, 1, 'Patron with no dateofbirth is always valid for any category'); > > $patron->dateofbirth( $today->clone->add( years => -12, months => -6, days => -1 ) ); >- is( $patron->is_category_valid, 0, 'Patron is 12, so his age is above allowed range 5-10 years'); >+ is( $patron->is_category_valid, 0, 'Patron is 12, so the age is above allowed range 5-10 years'); > > $patron->dateofbirth( $today->clone->add( years => -3, months => -6, days => -1 ) ); >- is( $patron->is_category_valid, 0, 'Patron is 3, so his age is below allowed range 5-10 years'); >+ is( $patron->is_category_valid, 0, 'Patron is 3, so the age is below allowed range 5-10 years'); > > $patron->dateofbirth( $today->clone->add( years => -7, months => -6, days => -1 ) ); >- is( $patron->is_category_valid, 1, 'Patron is 7, so his age perfectly suits allowed range 5-10 years'); >+ is( $patron->is_category_valid, 1, 'Patron is 7, so the age perfectly suits allowed range 5-10 years'); > > $patron->dateofbirth( $today->clone->add( years => -5, months => 0, days => 0 ) ); >- is( $patron->is_category_valid, 1, 'Patron celebrates the 5th birthday today, so he is allowed for this category'); >+ is( $patron->is_category_valid, 1, 'Patron celebrates the 5th birthday today, so the age is allowed for this category'); > > $patron->dateofbirth( $today->clone->add( years => -5, months => 0, days => 1 ) ); >- is( $patron->is_category_valid, 0, 'Patron will celebrate the 5th birthday tomorrow, so he is NOT allowed for this category'); >+ is( $patron->is_category_valid, 0, 'Patron will celebrate the 5th birthday tomorrow, so the age is NOT allowed for this category'); > > $patron->dateofbirth( $today->clone->add( years => -5, months => 0, days => -1 ) ); >- is( $patron->is_category_valid, 1, 'Patron celebrated the 5th birthday yesterday, so he is allowed for this category'); >+ is( $patron->is_category_valid, 1, 'Patron celebrated the 5th birthday yesterday, so the age is allowed for this category'); > > $patron->dateofbirth( $today->clone->add( years => -11, months => 0, days => 0 ) ); >- is( $patron->is_category_valid, 0, 'Patron celebrate the 11th birthday today, so he is NOT allowed for this category'); >+ is( $patron->is_category_valid, 0, 'Patron celebrate the 11th birthday today, so the age is NOT allowed for this category'); > > $patron->dateofbirth( $today->clone->add( years => -11, months => 0, days => 1 ) ); >- is( $patron->is_category_valid, 1, 'Patron will celebrate the 11th birthday tomorrow, so he is allowed for this category'); >+ is( $patron->is_category_valid, 1, 'Patron will celebrate the 11th birthday tomorrow, so the age is allowed for this category'); > > $patron->dateofbirth( $today->clone->add( years => -11, months => 0, days => -1 ) ); >- is( $patron->is_category_valid, 0, 'Patron celebrated the 11th birthday yesterday, so he is NOT allowed for this category'); >+ is( $patron->is_category_valid, 0, 'Patron celebrated the 11th birthday yesterday, so the age is NOT allowed for this category'); > > $patron->delete; > $category->delete; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17492
:
56805
|
56806
|
56874
|
56933
|
56934
|
56935
|
56936
|
56937
|
56976
|
56985
|
56986
|
56987
|
56988
|
56989
|
56990
|
56995
|
62860
|
67040
|
67041
|
67042
|
67850
|
67851
|
67867
|
67868
|
68139
|
68140
|
68141
|
68142
|
68143
|
68144
|
68145
|
91028
|
91029
|
91044
|
91045
|
91098
|
91099
|
91100