Bugzilla – Attachment 68244 Details for
Bug 19463
TestBuilder.t is failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19463: (Follow-up) Cosmetic changes
Bug-19463-Follow-up-Cosmetic-changes.patch (text/plain), 1.34 KB, created by
Marcel de Rooy
on 2017-10-18 12:08:15 UTC
(
hide
)
Description:
Bug 19463: (Follow-up) Cosmetic changes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-10-18 12:08:15 UTC
Size:
1.34 KB
patch
obsolete
>From 9b16af5600ca570480301cee4811e1cc1df42bb3 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 18 Oct 2017 13:59:06 +0200 >Subject: [PATCH] Bug 19463: (Follow-up) Cosmetic changes >Content-Type: text/plain; charset=utf-8 > >String::Random version 0.26 (on Jessie) does not yet support the rand_gen >parameter (0.27 does, newest is 0.29 on CPAN now). >So alt_rand is only used in determining the size on Jessie. >That might be enough though. >Adding a documention line in this regard. > >Removing the obsolete max parameter. > >Note: I timed alt_rand for the creation of a new Bytes::Random::Secure >object each time. But each call is about 0.1 milliseconds. So that >should be fine. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/lib/TestBuilder.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm >index d42372e..4ec6dba 100644 >--- a/t/lib/TestBuilder.pm >+++ b/t/lib/TestBuilder.pm >@@ -438,7 +438,8 @@ sub _gen_text { > my $regex = $size > 1 > ? '[A-Za-z][A-Za-z0-9_]{'.($size-1).'}' > : '[A-Za-z]'; >- my $random = String::Random->new( max => $size, rand_gen => \&alt_rand ); >+ my $random = String::Random->new( rand_gen => \&alt_rand ); >+ # rand_gen is only supported from 0.27 onward > return $random->randregex($regex); > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19463
:
68217
|
68218
|
68219
| 68244