@@ -, +, @@ --- Koha/Holds.pm | 2 +- misc/cronjobs/holds/cancel_unfilled_holds.pl | 9 +++++---- t/db_dependent/Holds.t | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) --- a/Koha/Holds.pm +++ a/Koha/Holds.pm @@ -46,7 +46,7 @@ returns a set of holds that are waiting from an existing set sub waiting { my ( $self ) = @_; - return $self->search( { found => 'w' } ); + return $self->search( { found => 'W' } ); } =head3 unfilled --- a/misc/cronjobs/holds/cancel_unfilled_holds.pl +++ a/misc/cronjobs/holds/cancel_unfilled_holds.pl @@ -39,16 +39,16 @@ cronlogaction(); =head1 NAME -cancel_waiting_holds.pl +cancel_unfilled_holds.pl =head1 SYNOPSIS -cancel_waiting_holds.pl +cancel_unfilled_holds.pl [-days][-library][-holidays] Options: -help brief help - -days cancel holds waiting this many days + -days cancel holds placed this many days ago which have not been filled -library [repeatable] limit to specified branch(es) -holidays skip holidays when calculating days waiting -v verbose @@ -67,7 +67,8 @@ Print full documentation and exit. =item B<-days> -Specify the number of days waiting upon which to cancel holds. +Specify the number of days waiting since a hold that remains unfilled was placed. +E.g. a value of 730 would cancel holds placed 2 years ago or more that have never been filled =item B<-library> --- a/t/db_dependent/Holds.t +++ a/t/db_dependent/Holds.t @@ -7,7 +7,7 @@ use t::lib::TestBuilder; use C4::Context; -use Test::More tests => 59; +use Test::More tests => 54; use MARC::Record; use C4::Biblio; use C4::Items; --