Bugzilla – Attachment 68364 Details for
Bug 18382
action_logs entry for module HOLDS, action SUSPEND is spammy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18382: [FOLLOW-UP] Ensure user can still enter an empty date
Bug-18382-FOLLOW-UP-Ensure-user-can-still-enter-an.patch (text/plain), 910 bytes, created by
Katrin Fischer
on 2017-10-21 22:31:48 UTC
(
hide
)
Description:
Bug 18382: [FOLLOW-UP] Ensure user can still enter an empty date
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-10-21 22:31:48 UTC
Size:
910 bytes
patch
obsolete
>From 10b33bb4cbc74f72338831201c0d9736bc1e67e5 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 18 Oct 2017 21:41:07 +0000 >Subject: [PATCH] Bug 18382: [FOLLOW-UP] Ensure user can still enter an empty > date > >Follow above test plan >Also check that you can suspend with no date > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/Hold.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index be05b1f..9bb7c93 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -91,8 +91,11 @@ sub suspend_hold { > } > > $self->suspend(1); >- $self->suspend_until( $dt->ymd ); >- >+ if ( defined $dt ){ >+ $self->suspend_until( $dt->ymd ); >+ } else { >+ $self->suspend_until( $dt ); >+ } > $self->store(); > > logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, Dumper($self->unblessed) ) >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18382
:
61842
|
63962
|
68281
|
68363
|
68364
|
72610
|
73149
|
73150
|
73317
|
73343
|
73420