Bugzilla – Attachment 68461 Details for
Bug 19298
allow_onshelf_holds is not calculated correctly in opac-shelves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19298: (QA follow-up) Remove GetBiblioData call
Bug-19298-QA-follow-up-Remove-GetBiblioData-call.patch (text/plain), 1.65 KB, created by
Marcel de Rooy
on 2017-10-24 12:52:23 UTC
(
hide
)
Description:
Bug 19298: (QA follow-up) Remove GetBiblioData call
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-10-24 12:52:23 UTC
Size:
1.65 KB
patch
obsolete
>From 2c2d3a4db3f650461fdb1691a34c7ea409a9ace4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 24 Oct 2017 14:44:19 +0200 >Subject: [PATCH] Bug 19298: (QA follow-up) Remove GetBiblioData call >Content-Type: text/plain; charset=utf-8 > >In order to do at least something for performance, we could replace >the call to GetBiblioData since we are already fetching biblio data >with Koha::Biblios. >Note that the fields bnotes and bi_notforloan are not used in shelves. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Tested that notes are also displayed now in non-xslt view. >Got the best results in performance with this change say 640ms; with the >first patch 740ms and without both 690ms. >--- > opac/opac-shelves.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-shelves.pl b/opac/opac-shelves.pl >index 1feaf57..d8e535c 100755 >--- a/opac/opac-shelves.pl >+++ b/opac/opac-shelves.pl >@@ -270,10 +270,10 @@ if ( $op eq 'view' ) { > my @items; > while ( my $content = $contents->next ) { > my $biblionumber = $content->biblionumber; >- my $this_item = GetBiblioData($biblionumber); >+ my $biblio = Koha::Biblios->find( $biblionumber ); >+ my $this_item = $biblio->unblessed; > my $record = GetMarcBiblio({ biblionumber => $biblionumber }); > my $framework = GetFrameworkCode( $biblionumber ); >- my $biblio = Koha::Biblios->find( $biblionumber ); > $record_processor->options({ > interface => 'opac', > frameworkcode => $framework >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19298
:
67116
|
67387
|
68460
|
68461