View | Details | Raw Unified | Return to bug 19038
Collapse All | Expand All

(-)a/C4/UsageStats.pm (-1 lines)
Lines 243-249 sub BuildReport { Link Here
243
        OpacMaintenance
243
        OpacMaintenance
244
        OpacPublic
244
        OpacPublic
245
        OpacSeparateHoldings
245
        OpacSeparateHoldings
246
        OPACShowBarcode
247
        OPACShowCheckoutName
246
        OPACShowCheckoutName
248
        OpacShowFiltersPulldownMobile
247
        OpacShowFiltersPulldownMobile
249
        OPACShowHoldQueueDetails
248
        OPACShowHoldQueueDetails
(-)a/installer/data/mysql/atomicupdate/bug_19038_remove_opacshowbarcode_syspref.perl (+21 lines)
Line 0 Link Here
1
$DBversion = 'XXX';
2
if( CheckVersion( $DBversion ) ) {
3
    my $hide_barcode = C4::Context->preference('OPACShowBarcode') ? 0 : 1;
4
5
    $dbh->do(q{
6
        DELETE FROM systempreferences
7
        WHERE
8
            variable='OPACShowBarcode'
9
    });
10
11
    # Configure column visibility if it isn't
12
    $dbh->do(q{
13
        INSERT IGNORE INTO columns_settings
14
            (module,page,tablename,columnname,cannot_be_toggled,is_hidden)
15
        VALUES
16
            ('opac','biblio-detail','holdingst','item_barcode',0,?)
17
    }, undef, $hide_barcode);
18
19
    SetVersion( $DBversion );
20
    print "Upgrade to $DBversion done (Bug 19038: Remove OPACShowBarcode syspref)\n";
21
}
(-)a/installer/data/mysql/sysprefs.sql (-1 lines)
Lines 378-384 INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` Link Here
378
('opacSerialDefaultTab','subscriptions','holdings|serialcollection|subscriptions','Define the default tab for serials in OPAC.','Choice'),
378
('opacSerialDefaultTab','subscriptions','holdings|serialcollection|subscriptions','Define the default tab for serials in OPAC.','Choice'),
379
('OPACSerialIssueDisplayCount','3','','Number of serial issues to display per subscription in the OPAC','Integer'),
379
('OPACSerialIssueDisplayCount','3','','Number of serial issues to display per subscription in the OPAC','Integer'),
380
('OPACShelfBrowser','1','','Enable/disable Shelf Browser on item details page. WARNING: this feature is very resource consuming on collections with large numbers of items.','YesNo'),
380
('OPACShelfBrowser','1','','Enable/disable Shelf Browser on item details page. WARNING: this feature is very resource consuming on collections with large numbers of items.','YesNo'),
381
('OPACShowBarcode','0','','Show items barcode in holding tab','YesNo'),
382
('OPACShowCheckoutName','0','','Displays in the OPAC the name of patron who has checked out the material. WARNING: Most sites should leave this off. It is intended for corporate or special sites which need to track who has the item.','YesNo'),
381
('OPACShowCheckoutName','0','','Displays in the OPAC the name of patron who has checked out the material. WARNING: Most sites should leave this off. It is intended for corporate or special sites which need to track who has the item.','YesNo'),
383
('OPACShowHoldQueueDetails','none','none|priority|holds|holds_priority','Show holds details in OPAC','Choice'),
382
('OPACShowHoldQueueDetails','none','none|priority|holds|holds_priority','Show holds details in OPAC','Choice'),
384
('OpacShowRecentComments','0',NULL,'If ON a link to recent comments will appear in the OPAC masthead','YesNo'),
383
('OpacShowRecentComments','0',NULL,'If ON a link to recent comments will appear in the OPAC masthead','YesNo'),
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref (-7 lines)
Lines 165-177 OPAC: Link Here
165
                  no: "Don't show"
165
                  no: "Don't show"
166
            - a link to recent comments in the OPAC masthead.
166
            - a link to recent comments in the OPAC masthead.
167
        -
167
        -
168
            - pref: OPACShowBarcode
169
              default: 0
170
              choices:
171
                  yes: Show
172
                  no: "Don't show"
173
            - the item's barcode on the holdings tab.
174
        -
175
            - pref: GoogleIndicTransliteration
168
            - pref: GoogleIndicTransliteration
176
              default: 0
169
              default: 0
177
              choices:
170
              choices:
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt (-3 / +2 lines)
Lines 1199-1206 Link Here
1199
        [% IF ( itemdata_itemnotes ) %]
1199
        [% IF ( itemdata_itemnotes ) %]
1200
                <th id="item_notes" data-colname="item_notes" class="notes">Notes</th>[% END %]
1200
                <th id="item_notes" data-colname="item_notes" class="notes">Notes</th>[% END %]
1201
                <th id="item_datedue" data-colname="item_datedue" class="date_due">Date due</th>
1201
                <th id="item_datedue" data-colname="item_datedue" class="date_due">Date due</th>
1202
        [% IF ( OPACShowBarcode ) %]
1202
                <th id="item_barcode" data-colname="item_barcode" class="barcode">Barcode</th>
1203
                <th id="item_barcode" data-colname="item_barcode" class="barcode">Barcode</th>[% END %]
1204
        [% IF holds_count.defined %]
1203
        [% IF holds_count.defined %]
1205
                <th id="item_holds" data-colname="item_holds">Item holds</th>
1204
                <th id="item_holds" data-colname="item_holds">Item holds</th>
1206
        [% ELSIF show_priority %]
1205
        [% ELSIF show_priority %]
Lines 1329-1335 Link Here
1329
                    <td class="status">[% INCLUDE 'item-status-schema-org.inc' item = ITEM_RESULT %][% INCLUDE 'item-status.inc' item = ITEM_RESULT %]</td>
1328
                    <td class="status">[% INCLUDE 'item-status-schema-org.inc' item = ITEM_RESULT %][% INCLUDE 'item-status.inc' item = ITEM_RESULT %]</td>
1330
                    [% IF ( itemdata_itemnotes ) %]<td class="notes" property="description">[% ITEM_RESULT.itemnotes %]</td>[% END %]
1329
                    [% IF ( itemdata_itemnotes ) %]<td class="notes" property="description">[% ITEM_RESULT.itemnotes %]</td>[% END %]
1331
                    <td class="date_due"><span title="[% ITEM_RESULT.datedue %]">[% ITEM_RESULT.datedue | $KohaDates as_due_date => 1 %]</span></td>
1330
                    <td class="date_due"><span title="[% ITEM_RESULT.datedue %]">[% ITEM_RESULT.datedue | $KohaDates as_due_date => 1 %]</span></td>
1332
                    [% IF ( OPACShowBarcode ) %]<td class="barcode" property="serialNumber">[% ITEM_RESULT.barcode %]</td>[% END %]
1331
                        <td class="barcode" property="serialNumber">[% ITEM_RESULT.barcode %]</td>
1333
                    [% IF holds_count.defined || show_priority %]
1332
                    [% IF holds_count.defined || show_priority %]
1334
                        <td class="holds_count">
1333
                        <td class="holds_count">
1335
                            [% IF holds_count.defined %] [% ITEM_RESULT.holds_count %] [% END %]
1334
                            [% IF holds_count.defined %] [% ITEM_RESULT.holds_count %] [% END %]
(-)a/opac/opac-detail.pl (-1 lines)
Lines 462-468 if ($session->param('busc')) { Link Here
462
462
463
$template->param( 'ItemsIssued' => CountItemsIssued( $biblionumber ) );
463
$template->param( 'ItemsIssued' => CountItemsIssued( $biblionumber ) );
464
$template->param('OPACShowCheckoutName' => C4::Context->preference("OPACShowCheckoutName") );
464
$template->param('OPACShowCheckoutName' => C4::Context->preference("OPACShowCheckoutName") );
465
$template->param('OPACShowBarcode' => C4::Context->preference("OPACShowBarcode") );
466
465
467
# adding items linked via host biblios
466
# adding items linked via host biblios
468
467
(-)a/t/db_dependent/UsageStats.t (-2 lines)
Lines 496-502 sub mocking_systempreferences_to_a_set_value { Link Here
496
        OpacMaintenance
496
        OpacMaintenance
497
        OpacPublic
497
        OpacPublic
498
        OpacSeparateHoldings
498
        OpacSeparateHoldings
499
        OPACShowBarcode
500
        OPACShowCheckoutName
499
        OPACShowCheckoutName
501
        OpacShowFiltersPulldownMobile
500
        OpacShowFiltersPulldownMobile
502
        OPACShowHoldQueueDetails
501
        OPACShowHoldQueueDetails
503
- 

Return to bug 19038