Bugzilla – Attachment 68529 Details for
Bug 19513
More changes to MarkIssueReturned.t (after bug 19487)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19513: Re-add AnonymousPatron-related tests
Bug-19513-Re-add-AnonymousPatron-related-tests.patch (text/plain), 3.50 KB, created by
Marcel de Rooy
on 2017-10-25 11:33:50 UTC
(
hide
)
Description:
Bug 19513: Re-add AnonymousPatron-related tests
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-10-25 11:33:50 UTC
Size:
3.50 KB
patch
obsolete
>From c9155d8003b77f58eee5282d1d9779d4a2081fc5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 24 Oct 2017 14:53:36 -0300 >Subject: [PATCH] Bug 19513: Re-add AnonymousPatron-related tests >Content-Type: text/plain; charset=utf-8 > >These tests are still useful. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >The AddMember call is considerably slowing it down. A call to TestBuilder >would be an improvement for performance. >--- > t/db_dependent/Circulation/MarkIssueReturned.t | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/Circulation/MarkIssueReturned.t b/t/db_dependent/Circulation/MarkIssueReturned.t >index d2cf238..28ad32d 100644 >--- a/t/db_dependent/Circulation/MarkIssueReturned.t >+++ b/t/db_dependent/Circulation/MarkIssueReturned.t >@@ -25,6 +25,7 @@ use t::lib::TestBuilder; > > use C4::Circulation; > use C4::Context; >+use C4::Members; > use Koha::Database; > > my $schema = Koha::Database->schema; >@@ -32,8 +33,6 @@ $schema->storage->txn_begin; > > my $builder = t::lib::TestBuilder->new; > >-t::lib::Mocks::mock_preference('AnonymousPatron', ''); >- > my $library = $builder->build({ source => 'Branch' }); > > C4::Context->_new_userenv('xxx'); >@@ -56,18 +55,31 @@ my $item = $builder->build( > } > } > ); >-my $issue = C4::Circulation::AddIssue( $patron, $item->{barcode} ); >- >-eval { C4::Circulation::MarkIssueReturned( $patron->{borrowernumber}, $item->{itemnumber}, 'dropbox_branch', 'returndate', 2 ) }; >-like ( $@, qr<Fatal error: the patron \(\d+\) .* AnonymousPatron>, 'Fatal error on anonymization' ); > >+subtest 'anonymous patron' => sub { >+ plan tests => 2; >+ # The next call will raise an error, because data are not correctly set >+ t::lib::Mocks::mock_preference('AnonymousPatron', ''); >+ my $issue = C4::Circulation::AddIssue( $patron, $item->{barcode} ); >+ eval { C4::Circulation::MarkIssueReturned( $patron->{borrowernumber}, $item->{itemnumber}, 'dropbox_branch', 'returndate', 2 ) }; >+ like ( $@, qr<Fatal error: the patron \(\d+\) .* AnonymousPatron>, 'AnonymousPatron is not set - Fatal error on anonymization' ); >+ Koha::Checkouts->find( $issue->issue_id )->delete; >+ >+ my $anonymous_borrowernumber = C4::Members::AddMember( categorycode => $patron_category->{categorycode}, branchcode => $library->{branchcode} ); >+ t::lib::Mocks::mock_preference('AnonymousPatron', $anonymous_borrowernumber); >+ $issue = C4::Circulation::AddIssue( $patron, $item->{barcode} ); >+ eval { C4::Circulation::MarkIssueReturned( $patron->{borrowernumber}, $item->{itemnumber}, 'dropbox_branch', 'returndate', 2 ) }; >+ is ( $@, q||, 'AnonymousPatron is set correctly - no error expected'); >+}; >+ >+my ( $issue_id, $issue ); > # The next call will return undef for invalid item number >-my $issue_id; > eval { $issue_id = C4::Circulation::MarkIssueReturned( $patron->{borrowernumber}, 'invalid_itemnumber', 'dropbox_branch', 'returndate', 0 ) }; > is( $@, '', 'No die triggered by invalid itemnumber' ); > is( $issue_id, undef, 'No issue_id returned' ); > > # In the next call we return the item and try it another time >+$issue = C4::Circulation::AddIssue( $patron, $item->{barcode} ); > eval { $issue_id = C4::Circulation::MarkIssueReturned( $patron->{borrowernumber}, $item->{itemnumber}, undef, undef, 0 ) }; > is( $issue_id, $issue->issue_id, "Item has been returned (issue $issue_id)" ); > eval { $issue_id = C4::Circulation::MarkIssueReturned( $patron->{borrowernumber}, $item->{itemnumber}, undef, undef, 0 ) }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19513
:
68385
|
68490
| 68529