Bugzilla – Attachment 68589 Details for
Bug 18389
Allow using MARC modification templates in bulkmarcimport.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18389: QA Followup - Fix tabs, note used template, info on verbose
Bug-18389-QA-Followup---Fix-tabs-note-used-templat.patch (text/plain), 2.28 KB, created by
Nick Clemens
on 2017-10-26 10:49:32 UTC
(
hide
)
Description:
Bug 18389: QA Followup - Fix tabs, note used template, info on verbose
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2017-10-26 10:49:32 UTC
Size:
2.28 KB
patch
obsolete
>From 6aeadb9d1ba527ca33d104e2cd888ff092aa2de8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 26 Oct 2017 10:46:03 +0000 >Subject: [PATCH] Bug 18389: QA Followup - Fix tabs, note used template, info > on verbose > >Fixed whitespace for QA tools >Added a verbose note when template found >Only print 'Modifying MARC' if verbose >--- > misc/migration_tools/bulkmarcimport.pl | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) > >diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl >index e444558..9a3b44c 100755 >--- a/misc/migration_tools/bulkmarcimport.pl >+++ b/misc/migration_tools/bulkmarcimport.pl >@@ -122,19 +122,21 @@ if(defined $localcust) { #local customize module > if($marc_mod_template ne '') { > my @templates = GetModificationTemplates(); > foreach my $this_template (@templates) { >- if($this_template->{'name'} eq $marc_mod_template) { >- if($marc_mod_template_id < 0) { >- $marc_mod_template_id = $this_template->{'template_id'}; >- } else { >- print "WARNING: MARC modification template name " . >- "'$marc_mod_template' matches multiple templates. " . >- "Please rename these templates\n"; >- exit 1; >- } >- } >+ if($this_template->{'name'} eq $marc_mod_template) { >+ if($marc_mod_template_id < 0) { >+ $marc_mod_template_id = $this_template->{'template_id'}; >+ } else { >+ print "WARNING: MARC modification template name " . >+ "'$marc_mod_template' matches multiple templates. " . >+ "Please rename these templates\n"; >+ exit 1; >+ } >+ } > } > if($marc_mod_template_id < 0) { >- die "Can't located MARC modification template '$marc_mod_template'\n"; >+ die "Can't located MARC modification template '$marc_mod_template'\n"; >+ } else { >+ print "Records will be modified using MARC modofication template: $marc_mod_template\n" if $verbose; > } > } > >@@ -288,7 +290,7 @@ RECORD: while ( ) { > } > SetUTF8Flag($record); > if($marc_mod_template_id > 0) { >- print "Modifying MARC\n"; >+ print "Modifying MARC\n" if $verbose; > ModifyRecordWithTemplate( $marc_mod_template_id, $record ); > } > &$localcust($record) if $localcust; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18389
:
61907
|
63353
|
63469
|
63851
|
66144
|
66379
|
66498
|
68587
|
68588
|
68589
|
68590
|
68591
|
68592