From a7e085a40d31e7e57a0778d704c6fd3268e558ee Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 26 Oct 2017 07:35:53 -0400 Subject: [PATCH] Bug 19533 - Hold pulldown for itemtype is empty if hold placement needs override Test Plan: 1) Enable AllowHoldPolicyOverride 2) Enable AllowHoldItemTypeSelection 3) Create a situation where adding a hold for a patron would trigger a tooManyReserves warning. 4) Note the itemtype pulldown is empty 5) Apply this patch 6) Reload the page 7) Itemtype pulldown should have values --- reserve/request.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/reserve/request.pl b/reserve/request.pl index f4cdc16..ee5eabc 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -485,6 +485,8 @@ foreach my $biblionumber (@biblionumbers) { # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules $item->{override} = 1; $num_override++; + + push( @available_itemtypes, $item->{itype} ) if $can_item_be_reserved eq 'tooManyReserves'; } # If none of the conditions hold true, then neither override nor available is set and the item cannot be checked -- 2.10.2