From 9ef6e3cd2fc09f33f824b4259663e5adca655f16 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 26 Oct 2017 07:40:04 -0400 Subject: [PATCH] Bug 11512 - Forced holds that violate issuing rules will never be filled Currently in Koha, if you choose to force a hold from the staff side that would contravened the current issuing rules, that hold will never be filled, as it is always skipped over by CheckReserves. This patch disallows overrideing except for tooManyReserves which are the only overridden holds that will be trapped. Test Plan: 1) Apply this patch 2) Attempt to override hold placement, only placements where the patron has too many holds already should be allowed --- reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reserve/request.pl b/reserve/request.pl index f4cdc16..7f22345 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -481,7 +481,7 @@ foreach my $biblionumber (@biblionumbers) { push( @available_itemtypes, $item->{itype} ); } - elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) { + elsif ( $can_item_be_reserved eq 'tooManyReserves' && C4::Context->preference('AllowHoldPolicyOverride') ) { # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules $item->{override} = 1; $num_override++; -- 2.10.2