Bugzilla – Attachment 68654 Details for
Bug 17989
Stricter control on source directory for html templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t
Bug-17989-QA-follow-up-Replace-bad-dots-in-Suggest.patch (text/plain), 1.26 KB, created by
Marcel de Rooy
on 2017-10-27 05:56:52 UTC
(
hide
)
Description:
Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-10-27 05:56:52 UTC
Size:
1.26 KB
patch
obsolete
>From 9a0d1c016ef5bdc242111a711c1843404efd9d1a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 27 Oct 2017 07:49:51 +0200 >Subject: [PATCH] Bug 17989: (QA follow-up) Replace bad dots in > SuggestionEngine_ExplodedTerms.t >Content-Type: text/plain; charset=utf-8 > >SuggestionEngine_ExplodedTerms.t uses paths like /../.. or /.. in order >to find a template in opac-tmpl. >Sub badtemplatecheck does not like these paths. >Using Cwd::abs_path to resolve the situation (rel2abs does not). > >Test plan: >Run again t/db_dependent/SuggestionEngine_ExplodedTerms.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/SuggestionEngine_ExplodedTerms.t | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/SuggestionEngine_ExplodedTerms.t b/t/db_dependent/SuggestionEngine_ExplodedTerms.t >index 42b2ba4..bac1b41 100644 >--- a/t/db_dependent/SuggestionEngine_ExplodedTerms.t >+++ b/t/db_dependent/SuggestionEngine_ExplodedTerms.t >@@ -3,6 +3,7 @@ > use strict; > use warnings; > >+use Cwd qw/abs_path/; > use File::Basename; > use File::Spec; > use Test::More; >@@ -34,7 +35,7 @@ sub get_where { > else { > $location .= '/..'; > } >- return $location; >+ return abs_path($location); > } > > my $langModule; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17989
:
65277
|
65278
|
65279
|
65280
|
65281
|
66272
|
66273
|
66274
|
66275
|
66276
|
66317
|
66318
|
66319
|
66320
|
66321
|
67514
|
67515
|
67516
|
67517
|
67518
|
68654
|
68667
|
68668
|
68669
|
68670
|
68671
|
68672
|
68842
|
68843